#2687 - Include mimeo python module

modules/adblockplus/manifests/web/mimeo.pp

 # == Class: adblockplus::web::mimeo
 #
 # Class adblockplus::web::mimeo registers the information received in a
 # http/s petition with an specified format in an specific output.
 #
 # === Parameters:
 #
 # [*format*]
 #   A string containing the desired format for logging.
 #
 #   '$remote_addr - - [$time_local] "$request" $status $bytes_sent "$http_referer"'
 #
 # [*port*]
 #   An integer to setup the port where the script will be listening, defaults
 #   to 8000.
 #
 # [*response*]
 #   A string (like format parameter) representing the response sent to the
 #   client.
 #
-# [*output*]
-#   A string containg the path to the file where the logs will be written.
-#   the special char `-` represents stdout.
-#
 class adblockplus::web::mimeo (
   $format = '',
   $port = 8000,
   $response = '',
-  $output = '-',

[mathias, 2017/08/21 07:37:42]

With that one being the default now, how exactly can one access the data in
development?

[f.lopez, 2017/08/21 19:54:12]

Done.

 ){
+  include adblockplus
 
   ensure_packages(['python3'])
 
-  file {"/usr/local/bin/mimeo.py":
+  realize(File['/var/adblockplus'])
+
+  file {'/var/adblockplus/mimeo':
+    ensure => 'directory',
+    mode => '0755',
+    owner => 'root',
+    require => File['/var/adblockplus'],
+  }
+
+  file {'/usr/local/bin/mimeo.py':
     ensure => 'present',
     owner => 'root',
     group => 'root',
     mode => 0755,
     source => 'puppet:///modules/adblockplus/mimeo.py',
     require => Package['python3'],
   }
 
-  file {"/etc/systemd/system/mimeo.service":
+  file {'/etc/systemd/system/mimeo.service':
     ensure => 'present',
     owner => 'root',
     group => 'root',
     mode => 0644,
     content => template('adblockplus/mimeo.service.erb'),
     require => File['/usr/local/bin/mimeo.py'],
   }
 
   Exec{
     path => ['/usr/bin', '/bin'],
   }
 
-  exec {"enable-service-mimeo":
+  exec {'enable-service-mimeo':
     command => 'systemctl enable mimeo.service',
     user => 'root',
     unless => 'systemctl is-enabled mimeo.service',
-    require => File["/etc/systemd/system/mimeo.service"],
+    require => File['/etc/systemd/system/mimeo.service'],
   }
 
-  service {"mimeo":
+  service {'mimeo':
     ensure => 'running',
     hasrestart => false,
     provider => 'systemd',
-    require => Exec["enable-service-mimeo"],
+    require => Exec['enable-service-mimeo'],
+    subscribe => File['/usr/local/bin/mimeo.py'],
   }
 
-  exec {"reload-mimeo-daemon":
+  exec {'reload-mimeo-daemon':
     notify => Service['mimeo'],
     command => 'systemctl daemon-reload',
-    subscribe => [
-      File["/etc/systemd/system/mimeo.service"],
-      File["/usr/local/bin/mimeo.py"],

[mathias, 2017/08/21 07:37:42]

Why should changing the Python script require a daemon-reload? IMHO the
Exec['reload-mimeo-daemon'] should subscribe to
File['/etc/systemd/system/mimeo.service'], and Service['mimeo'] should subscribe
to File['/usr/local/bin/mimeo.py'].

[f.lopez, 2017/08/21 19:54:12]

Done.

-    ],
+    subscribe => File['/etc/systemd/system/mimeo.service'],
     refreshonly => true,
   }
 }