#2687 - Include mimeo python module

modules/adblockplus/files/mimeo.py

 #!/usr/bin/env python3
 
 import argparse
 import re
 import sys
 import threading
 import traceback
 
 from http.server import BaseHTTPRequestHandler, HTTPServer
 from string import Template
@@ skipping 54 matching lines @@
     parser.add_argument('--response', action='store',
                         type=str, nargs='?', default='OK',
                         help='The response send to the client')
     parser.add_argument('--format', action='store',
                         type=str, nargs='?',
                         default=DEFAULT_LOG,
                         help='Format of the log ouput')
     parser.add_argument('output', action='store',
                         type=str, nargs='?', default='-',
                         help='The file where the logs will be written')
+    args = parser.parse_args()
+    if args.output and args.output != '-':
+        fh = open(args.output, 'a')
+    else:
+        fh = open(sys.stdout.fileno(), 'w', closefd=False)
     try:

[mathias, 2017/08/21 20:07:38]

The `try` block should not start before `fh` is defined. Otherwise you may
trigger an Exception in the `finally` block, e.g. when `parser.parse_args()`
raises an exception.

[f.lopez, 2017/08/22 16:52:42]

Done.

-        args = parser.parse_args()
-        if args.output and args.output != '-':
-            fh = open(args.output, 'a')
-        else:
-            fh = open(sys.stdout.fileno(), 'w', closefd=False)
         Handler.output = fh
         Handler.format = args.format
         Handler.response = args.response
         server_address = ('', args.port)
         httpd = HTTPServer(server_address, Handler)
         httpd.serve_forever()
     finally:
         fh.close()