Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/DefaultSubscriptions.java

Issue 29505565: Issue 5237 - Correct filter lists not applied on other language installation (Closed)
Left Patch Set: Issue 5237 - Correct filter lists not applied on other language installation Created Aug. 4, 2017, 2:30 p.m.
Right Patch Set: Fixed typo in SubscriptionUtils Created Aug. 15, 2017, 7:31 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-2016 Eyeo GmbH 3 * Copyright (C) 2006-2016 Eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 public DefaultSubscriptionInfo getForUrl(final String url) 86 public DefaultSubscriptionInfo getForUrl(final String url)
87 { 87 {
88 return this.urlMap.get(url); 88 return this.urlMap.get(url);
89 } 89 }
90 90
91 public DefaultSubscriptionInfo getForUrl(final URL url) 91 public DefaultSubscriptionInfo getForUrl(final URL url)
92 { 92 {
93 return url != null ? this.getForUrl(url.toString()) : null; 93 return url != null ? this.getForUrl(url.toString()) : null;
94 } 94 }
95 95
96 List<DefaultSubscriptionInfo> getAdsSubscriptions() 96 public List<DefaultSubscriptionInfo> getAdsSubscriptions()
anton 2017/08/08 05:43:41 why not public (package now)?
jens 2017/08/08 13:53:05 I thought it was to keep this method package-priva
anton 2017/08/11 11:25:07 That looks strange. Please consider making it 'pri
jens 2017/08/11 13:27:23 Acknowledged.
97 { 97 {
98 return adsSubscriptions; 98 return adsSubscriptions;
99 } 99 }
100 100
101 private void listSubscriptions(final List<DefaultSubscriptionInfo> output) 101 private void listSubscriptions(final List<DefaultSubscriptionInfo> output)
102 { 102 {
103 for (final DefaultSubscriptionInfo s : this.subscriptions) 103 for (final DefaultSubscriptionInfo s : this.subscriptions)
104 { 104 {
105 this.listSubscriptions(s, output); 105 this.listSubscriptions(s, output);
106 } 106 }
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 } 284 }
285 } 285 }
286 } 286 }
287 287
288 @Override 288 @Override
289 public String toString() 289 public String toString()
290 { 290 {
291 return this.linearSubscriptions.toString(); 291 return this.linearSubscriptions.toString();
292 } 292 }
293 } 293 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld