Issue 5237 - Correct filter lists not applied on other language installation

adblockplussbrowser/src/org/adblockplus/sbrowser/contentblocker/engine/Engine.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2016 Eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 50 matching lines @@
 import android.util.Log;
 
 public final class Engine
 {
   private static final String TAG = Engine.class.getSimpleName();
 
   public static final String USER_FILTERS_TITLE = "__filters";
   public static final String USER_EXCEPTIONS_TITLE = "__exceptions";
 
   public static final String SBROWSER_APP_ID = "com.sec.android.app.sbrowser";
   public static final String EASYLIST_URL = "https://easylist-downloads.adblockplus.org/easylist.txt";

[anton, 2017/08/08 05:43:41]

what's the point of changing order? seems to be not related to the task

[jens, 2017/08/08 13:53:05]

I moved it to group it together with the other public constants, as it was
private before. Isn't that okay for the sake of order?

   private static final String ACTION_OPEN_SETTINGS = "com.samsung.android.sbrowser.contentBlocker.ACTION_SETTING";
   private static final String ACTION_UPDATE = "com.samsung.android.sbrowser.contentBlocker.ACTION_UPDATE";
 
   public static final String SUBSCRIPTIONS_EXCEPTIONSURL = "subscriptions_exceptionsurl";
 
   // The value below specifies an interval of [x, 2*x[, where x =
   // INITIAL_UPDATE_CHECK_DELAY
   private static final long INITIAL_UPDATE_CHECK_DELAY = 5 * DateUtils.SECOND_IN_MILLIS;
   private static final long UPDATE_CHECK_INTERVAL = 30 * DateUtils.MINUTE_IN_MILLIS;
   private static final long BROADCAST_COMBINATION_DELAY = 2500;
@@ skipping 310 matching lines @@
         getFilterCacheDir(context));
 
     try (final InputStream prefsJson = context.getResources().openRawResource(R.raw.prefs))
     {
       engine.jsonPrefs = JSONPrefs.create(prefsJson);
     }
 
     Log.d(TAG, "Finished reading JSON preferences");
 
     // Check if this is a fresh start, if so: initialize bundled easylist.
     engine.wasFirstRun = engine.subscriptions.wasUnitialized();

[anton, 2017/08/08 05:43:41]

not related to this task, but anyway.
What is `wasUnitialized`, was it meant to be 'wasInitialized?'

Please confirm it's saved correctly between app  launches (in order NOT to have
`wasFirstRun`= true next app launch).

[jens, 2017/08/08 13:53:05]

Yeah, that's a typo. We should fix that in the next noissue commit.

I double checked it again and wasFirstRun is only true when starting the app for
the first time or when you wipe the app date manually (which is the intended
behavior, I think).

     if (engine.subscriptions.wasUnitialized())
     {
       Log.d(TAG, "Subscription storage was uninitialized, initializing...");
 
       try (final InputStream easylistTxt = context.getResources().openRawResource(R.raw.easylist))
       {
         final Subscription easylist = engine.subscriptions.add(Subscription
             // Use bundled EasyList as default and update it with locale specific list later
             // see: https://issues.adblockplus.org/ticket/5237
             .create(SubscriptionUtils.chooseDefaultSubscriptionUrl(engine.defaultSubscriptions.getAdsSubscriptions()))
@@ skipping 368 matching lines @@
   {
     this.downloader.connectivityChanged();
   }
 
   public interface SubscriptionUpdateCallback
   {
     void subscriptionUpdateRequested(boolean enabled);
     void subscriptionUpdatedApplied();
   }
 }