Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(760)

Issue 29505568: Issue 5355 - Fix line height on adblockplus.org (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 10 months ago by ire
Modified:
2 years, 9 months ago
Reviewers:
juliandoucette
CC:
rossg, scott, Robert Raceanu
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Issue 5355 - Fix line height on adblockplus.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M static/css/main.css View 2 chunks +2 lines, -0 lines 0 comments Download
M static/css/main-desktop.css View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4
ire
2 years, 10 months ago (2017-08-04 14:39:05 UTC) #1
juliandoucette
LGTM But I think we should test this before deploying. CC +Ross +Scott This Patchset ...
2 years, 10 months ago (2017-08-07 14:21:57 UTC) #2
juliandoucette
Note: I meant to CC Robert instead of Ross. Sorry about that Ross. I talked ...
2 years, 10 months ago (2017-08-08 14:13:17 UTC) #3
juliandoucette
2 years, 9 months ago (2017-08-16 14:23:31 UTC) #4
On August 15th, Ross wrote:

Hey Julian,

I've been using this patched version of web.adblockplus.org whenever I needed to
look up docs for the last week and have browsed through all of the major pages.
It all looks fine, the documentation is still readable, translated pages and
right-to-left layouts all work. 

I couldn't really find any real issues. Some items look like they could use a
little less line-height (the three feature icons/text items under the adblock
browser block and the small grey subtext), but that's quite subjective. 

Tested in:
- IE 9, IE 11, Edge
- Chrome 49, 59 (Desktop), 59 (Android)
- Firefox 49, 54 
- Safari 8, 10 (Desktop), 10 (iOS)

Best regards,
Ross
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5