Issue 5450 - don't expose std::shared_ptr<JsEngine>

src/FilterEngine.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 181 matching lines @@
   FilterEnginePtr filterEngine(new FilterEngine(jsEngine));
   {
     // TODO: replace weakFilterEngine by this when it's possible to control the
     // execution time of the asynchronous part below.
     std::weak_ptr<FilterEngine> weakFilterEngine = filterEngine;
     auto isSubscriptionDownloadAllowedCallback = params.isSubscriptionDownloadAllowedCallback;
     jsEngine->SetEventCallback("_isSubscriptionDownloadAllowed", [weakFilterEngine, isSubscriptionDownloadAllowedCallback](JsValueList&& params){
       auto filterEngine = weakFilterEngine.lock();
       if (!filterEngine)
         return;
-      auto jsEngine = filterEngine->GetJsEngine();
+      auto& jsEngine = filterEngine->GetJsEngine();
 
       // param[0] - nullable string Prefs.allowed_connection_type
       // param[1] - function(Boolean)
       bool areArgumentsValid = params.size() == 2 && (params[0].IsNull() || params[0].IsString()) && params[1].IsFunction();
       assert(areArgumentsValid && "Invalid argument: there should be two args and the second one should be a function");
       if (!areArgumentsValid)
         return;
       if (!isSubscriptionDownloadAllowedCallback)
       {
-        params[1].Call(jsEngine->NewValue(true));
+        params[1].Call(jsEngine.NewValue(true));
         return;
       }
-      auto valuesID = jsEngine->StoreJsValues(params);
+      auto valuesID = jsEngine.StoreJsValues(params);
       auto callJsCallback = [weakFilterEngine, valuesID](bool isAllowed)
       {
         auto filterEngine = weakFilterEngine.lock();
         if (!filterEngine)
           return;
-        auto jsEngine = filterEngine->GetJsEngine();
-        auto jsParams = jsEngine->TakeJsValues(valuesID);
-        jsParams[1].Call(jsEngine->NewValue(isAllowed));
+        auto& jsEngine = filterEngine->GetJsEngine();
+        auto jsParams = jsEngine.TakeJsValues(valuesID);
+        jsParams[1].Call(jsEngine.NewValue(isAllowed));
       };
       std::string allowedConnectionType = params[0].IsString() ? params[0].AsString() : std::string();
       isSubscriptionDownloadAllowedCallback(params[0].IsString() ? &allowedConnectionType : nullptr, callJsCallback);
     });
   }
   
   jsEngine->SetEventCallback("_init", [jsEngine, filterEngine, onCreated](JsValueList&& params)
   {
     filterEngine->firstRun = params.size() && params[0].AsBool();
     onCreated(filterEngine);
     jsEngine->RemoveEventCallback("_init");
   });
 
   std::weak_ptr<FilterEngine> weakFilterEngine = filterEngine;
   filterEngine->SetFilterChangeCallback([weakFilterEngine](const std::string& reason, JsValue&&)
   {
     auto filterEngine = weakFilterEngine.lock();
     if (!filterEngine)
       return;
     if (reason == "save")
-      filterEngine->GetJsEngine()->NotifyLowMemory();
+      filterEngine->GetJsEngine().NotifyLowMemory();
   });
 
   // Lock the JS engine while we are loading scripts, no timeouts should fire
   // until we are done.
   const JsContext context(*jsEngine);
   // Set the preconfigured prefs
   auto preconfiguredPrefsObject = jsEngine->NewObject();
   for (const auto& pref : params.preconfiguredPrefs)
   {
     preconfiguredPrefsObject.SetProperty(pref.first, pref.second);
@@ skipping 336 matching lines @@
     FilterPtr filter = GetWhitelistingFilter(currentUrl, contentTypeMask, parentUrl);
     if (filter)
     {
       return filter;
     }
     currentUrl = parentUrl;
   }
   while (urlIterator != documentUrls.end());
   return FilterPtr();
 }