Issue 5450 - don't expose std::shared_ptr<JsEngine>

src/Platform.cpp

 /*
 * This file is part of Adblock Plus <https://adblockplus.org/>,
 * Copyright (C) 2006-2017 eyeo GmbH
 *
 * Adblock Plus is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License version 3 as
 * published by the Free Software Foundation.
 *
 * Adblock Plus is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 54 matching lines @@
 }
 
 void Platform::SetUpJsEngine(const AppInfo& appInfo)
 {
   std::lock_guard<std::mutex> lock(modulesMutex);
   if (jsEngine)
     return;
   jsEngine = JsEngine::New(appInfo, *this);
 }
 
-std::shared_ptr<JsEngine> Platform::GetJsEngine()
+JsEngine& Platform::GetJsEngine()
 {
   SetUpJsEngine();
-  return jsEngine;
+  return *jsEngine;
 }
 
 void Platform::CreateFilterEngineAsync(const FilterEngine::CreationParameters& parameters,
   const OnFilterEngineCreatedCallback& onCreated)
 {
   std::shared_ptr<std::promise<FilterEnginePtr>> filterEnginePromise;
   {
     std::lock_guard<std::mutex> lock(modulesMutex);
     if (filterEngine.valid())
       return;
     filterEnginePromise = std::make_shared<std::promise<FilterEnginePtr>>();
     filterEngine = filterEnginePromise->get_future();
   }
 
-  FilterEngine::CreateAsync(GetJsEngine(), [this, onCreated, filterEnginePromise](const FilterEnginePtr& filterEngine)
+  GetJsEngine(); // ensures that JsEngine is instantiated
+  FilterEngine::CreateAsync(jsEngine, [this, onCreated, filterEnginePromise](const FilterEnginePtr& filterEngine)
   {
     filterEnginePromise->set_value(filterEngine);
     if (onCreated)
       onCreated(filterEngine);
   }, parameters);
 }
 
 FilterEnginePtr Platform::GetFilterEngine()
 {
   CreateFilterEngineAsync();
@@ skipping 12 matching lines @@
 
 IWebRequest& Platform::GetWebRequest()
 {
   return *webRequest;
 }
 
 LogSystem& Platform::GetLogSystem()
 {
   return *logSystem;
 }