Issue 5450 - don't expose std::shared_ptr<JsEngine>

test/AppInfoJsObject.cpp

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 12 matching lines @@
 {
   AdblockPlus::AppInfo appInfo;
   appInfo.version = "1";
   appInfo.name = "3";
   appInfo.application = "4";
   appInfo.applicationVersion = "5";
   appInfo.locale = "2";
   appInfo.developmentBuild = true;
   AdblockPlus::Platform platform{ThrowingPlatformCreationParameters()};
   platform.SetUpJsEngine(appInfo);
-  ASSERT_EQ("1", platform.GetJsEngine()->Evaluate("_appInfo.version").AsString());
-  ASSERT_EQ("3", platform.GetJsEngine()->Evaluate("_appInfo.name").AsString());
-  ASSERT_EQ("4", platform.GetJsEngine()->Evaluate("_appInfo.application").AsString());
-  ASSERT_EQ("5", platform.GetJsEngine()->Evaluate("_appInfo.applicationVersion").AsString());
-  ASSERT_EQ("2", platform.GetJsEngine()->Evaluate("_appInfo.locale").AsString());
-  ASSERT_TRUE(platform.GetJsEngine()->Evaluate("_appInfo.developmentBuild").AsBool());
+  ASSERT_EQ("1", platform.GetJsEngine().Evaluate("_appInfo.version").AsString());
+  ASSERT_EQ("3", platform.GetJsEngine().Evaluate("_appInfo.name").AsString());
+  ASSERT_EQ("4", platform.GetJsEngine().Evaluate("_appInfo.application").AsString());
+  ASSERT_EQ("5", platform.GetJsEngine().Evaluate("_appInfo.applicationVersion").AsString());
+  ASSERT_EQ("2", platform.GetJsEngine().Evaluate("_appInfo.locale").AsString());
+  ASSERT_TRUE(platform.GetJsEngine().Evaluate("_appInfo.developmentBuild").AsBool());
 }
 
 TEST(AppInfoJsObjectTest, DefaultPropertyValues)
 {
   AdblockPlus::Platform platform{ThrowingPlatformCreationParameters()};
-  platform.SetUpJsEngine();
-  ASSERT_EQ("", platform.GetJsEngine()->Evaluate("_appInfo.version").AsString());
-  ASSERT_EQ("", platform.GetJsEngine()->Evaluate("_appInfo.name").AsString());
-  ASSERT_EQ("", platform.GetJsEngine()->Evaluate("_appInfo.application").AsString());
-  ASSERT_EQ("", platform.GetJsEngine()->Evaluate("_appInfo.applicationVersion").AsString());
-  ASSERT_EQ("", platform.GetJsEngine()->Evaluate("_appInfo.locale").AsString());
-  ASSERT_FALSE(platform.GetJsEngine()->Evaluate("_appInfo.developmentBuild").AsBool());
+  ASSERT_EQ("", platform.GetJsEngine().Evaluate("_appInfo.version").AsString());
+  ASSERT_EQ("", platform.GetJsEngine().Evaluate("_appInfo.name").AsString());
+  ASSERT_EQ("", platform.GetJsEngine().Evaluate("_appInfo.application").AsString());
+  ASSERT_EQ("", platform.GetJsEngine().Evaluate("_appInfo.applicationVersion").AsString());
+  ASSERT_EQ("", platform.GetJsEngine().Evaluate("_appInfo.locale").AsString());
+  ASSERT_FALSE(platform.GetJsEngine().Evaluate("_appInfo.developmentBuild").AsBool());
 }