Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: include/AdblockPlus/Platform.h

Issue 29508569: Issue 5450 - don't expose std::shared_ptr<JsEngine> (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: Created Aug. 7, 2017, 8:39 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/AdblockPlus/FilterEngine.h ('k') | shell/src/GcCommand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/AdblockPlus/Platform.h
diff --git a/include/AdblockPlus/Platform.h b/include/AdblockPlus/Platform.h
index e40823f10ffa12b1d774854f38ac7c7b8a1271ff..9c89eda556d28d207a33600bda25f2e76e851ce5 100644
--- a/include/AdblockPlus/Platform.h
+++ b/include/AdblockPlus/Platform.h
@@ -104,7 +104,7 @@ namespace AdblockPlus
* Retrieves the `JsEngine` instance. It calls SetUpJsEngine if JsEngine is
* not initialized yet.
*/
- std::shared_ptr<JsEngine> GetJsEngine();
+ JsEngine& GetJsEngine();
/**
* Ensures that FilterEngine is constructed. Only the first call is effective.
« no previous file with comments | « include/AdblockPlus/FilterEngine.h ('k') | shell/src/GcCommand.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld