Unified Diff: test/Notification.cpp
Issue 29508569:
Issue 5450 - don't expose std::shared_ptr<JsEngine> (Closed)
Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set:
Created Aug. 7, 2017, 8:39 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« test/JsValue.cpp ('k')
|
test/Prefs.cpp » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: test/Notification.cpp |
| diff --git a/test/Notification.cpp b/test/Notification.cpp |
| index e96a5c6fe5bf8dbe5556bb6a7ef270552a6eb246..4c4ec8d3afcb5294e7cab7cdd7c133d1512dd49d 100644 |
| --- a/test/Notification.cpp |
| +++ b/test/Notification.cpp |
| @@ -27,10 +27,9 @@ namespace |
| { |
| typedef std::shared_ptr<FilterEngine> FilterEnginePtr; |
| - class NotificationTest : public ::testing::Test |
| + class NotificationTest : public BaseJsTest |
| { |
| protected: |
| - std::unique_ptr<Platform> platform; |
| FilterEnginePtr filterEngine; |
| void SetUp() |
| { |
| @@ -45,7 +44,7 @@ namespace |
| void AddNotification(const std::string& notification) |
| { |
| - filterEngine->GetJsEngine()->Evaluate("(function()" |
| + GetJsEngine().Evaluate("(function()" |
| "{" |
| "require('notification').Notification.addNotification(" + notification + ");" |
| "})();"); |
« no previous file with comments
|
« test/JsValue.cpp ('k')
|
test/Prefs.cpp » ('j')
|
no next file with comments »
