Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: build.py

Issue 29508667: Issue 4354, 4355 - handle dirty/outdated repos on release (Closed)
Patch Set: Created Aug. 7, 2017, 2:13 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | releaseAutomation.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build.py
diff --git a/build.py b/build.py
index aca63d4a7c0a7f244c3ddfc116d8f823de2297b5..ee2447d8e118955a0b711532329cdc7e30dc078d 100644
--- a/build.py
+++ b/build.py
@@ -424,6 +424,7 @@ def generateDocs(baseDir, scriptName, opts, args, type):
def runReleaseAutomation(baseDir, scriptName, opts, args, type):
+ path = 'default'
kzar 2017/08/07 14:59:59 This change seems unrelated?
tlucas 2017/08/07 15:42:06 Acknowledged.
keyFile = None
downloadsRepo = os.path.join(baseDir, '..', 'downloads')
for option, value in opts:
@@ -431,6 +432,8 @@ def runReleaseAutomation(baseDir, scriptName, opts, args, type):
keyFile = value
elif option in ('-d', '--downloads'):
downloadsRepo = value
+ elif option in ('-p', '--path'):
+ path = value
if len(args) == 0:
print 'No version number specified for the release'
@@ -448,7 +451,7 @@ def runReleaseAutomation(baseDir, scriptName, opts, args, type):
return
import buildtools.releaseAutomation as releaseAutomation
- releaseAutomation.run(baseDir, type, version, keyFile, downloadsRepo)
+ releaseAutomation.run(baseDir, type, version, keyFile, downloadsRepo, path)
def updatePSL(baseDir, scriptName, opts, args, type):
@@ -524,6 +527,7 @@ with addCommand(runReleaseAutomation, 'release') as command:
command.description = 'Note: If you are not the project owner then you ' "probably don't want to run this!\n\n" 'Runs release automation: creates downloads for the new version, tags ' 'source code repository as well as downloads and buildtools repository.'
command.addOption('File containing private key and certificates required to sign the release.', short='k', long='key', value='file', types=('chrome', 'safari', 'edge'))
command.addOption('Directory containing downloads repository (if omitted ../downloads is assumed)', short='d', long='downloads', value='dir')
+ command.addOption('Name of the path to use (if omitted "default" os assumed)', short='p', long='path', value='path')
command.params = '[options] <version>'
command.supportedTypes = ('gecko', 'chrome', 'safari', 'edge')
« no previous file with comments | « no previous file | releaseAutomation.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld