Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(401)

Issue 29508671: Testing new options page with the extension (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 4 months ago by saroyanm
Modified:
1 year, 3 months ago
Reviewers:
CC:
wspee, Thomas Greiner
Visibility:
Public.

Description

This is a patch for testing the new options page with current chrome devbuild, in order to make this work you need to have a root directory with dependent repositories: /adblockplus /adblockpluschrome (apply current patch here) /adblockpluscore /adblockplusui /buildtools After that you can build the test environment from "/adblockpluschrome" using: python build.py -t chrome devenv After build go to chrome://extensions(in chrome browser), set Developer mode and load /adblockpluschrome/devenv.chrome

Patch Set 1 : #

Patch Set 2 : Added introduced new settings #

Total comments: 1

Patch Set 3 : Fixed pfaa link #

Patch Set 4 : Rebased #

Patch Set 5 : Rebased #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : rebased #

Patch Set 9 : #

Patch Set 10 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M dependencies View 1 2 3 4 5 6 7 9 1 chunk +1 line, -1 line 0 comments Download
M lib/prefs.js View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M metadata.chrome View 1 2 3 4 5 6 7 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 2
saroyanm
I'll update this soon with the new introduced settings.
2 years, 2 months ago (2017-09-27 15:17:53 UTC) #1
saroyanm
2 years, 2 months ago (2017-09-27 15:31:36 UTC) #2

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5