Issue 29508671: Testing new options page with the extension

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29508671: Testing new options page with the extension (Closed)

Created:
Aug. 7, 2017, 2:21 p.m. by saroyanm

Modified:
Sept. 7, 2018, 2:55 p.m.

Reviewers:

CC:
wspee, Thomas Greiner

Visibility:
Public.

Description

This is a patch for testing the new options page with current chrome devbuild, in order to make this work you need to have a root directory with dependent repositories: /adblockplus /adblockpluschrome (apply current patch here) /adblockpluscore /adblockplusui /buildtools After that you can build the test environment from "/adblockpluschrome" using: python build.py -t chrome devenv After build go to chrome://extensions(in chrome browser), set Developer mode and load /adblockpluschrome/devenv.chrome

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -1 line)			Patch
M	dependencies	View	1 2 3 4 5 6 7 9	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/prefs.js	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	metadata.chrome	View	1 2 3 4 5 6 7	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

saroyanm

I'll update this soon with the new introduced settings.

Sept. 27, 2017, 3:17 p.m. (2017-09-27 15:17:53 UTC) #1

saroyanm

Sept. 27, 2017, 3:31 p.m. (2017-09-27 15:31:36 UTC) #2

https://codereview.adblockplus.org/29508671/diff/29557710/lib/prefs.js
File lib/prefs.js (right):

https://codereview.adblockplus.org/29508671/diff/29557710/lib/prefs.js#newcode93
lib/prefs.js:93: * @see
https://adblockplus.org/en/preferences#subscriptions_exceptionsurl_privacy
We probably need to update this page.

Expand All Messages | Collapse All Messages