Issue 5347 - Check for browserAction API support

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 309 matching lines @@
   let BrowserAction = function(tabId)
   {
     this._tabId = tabId;
     this._changes = null;
   };
   BrowserAction.prototype = {
     _applyChanges()
     {
       if ("iconPath" in this._changes)
       {
+        // Firefox for Android displays the browser action not as an icon but
+        // as a menu item. There is no icon, but such an option may be added in
+        // the future.
+        // https://bugzilla.mozilla.org/show_bug.cgi?id=1331746
         if ("setIcon" in chrome.browserAction)

[Wladimir Palant, 2017/08/16 10:52:07]

Here and below, maybe add a comment explaining which applications don't
currently have this feature? You can also link to
https://bugzilla.mozilla.org/show_bug.cgi?id=1331746 here. It helps knowing when
we can remove the check.

[Manish Jethani, 2017/08/16 11:45:42]

Done.

         {
           chrome.browserAction.setIcon({
             tabId: this._tabId,
             path: {
               16: this._changes.iconPath.replace("$size", "16"),
               19: this._changes.iconPath.replace("$size", "19"),
               20: this._changes.iconPath.replace("$size", "20"),
               32: this._changes.iconPath.replace("$size", "32"),
               38: this._changes.iconPath.replace("$size", "38"),
               40: this._changes.iconPath.replace("$size", "40")
             }
           });
         }
       }
 
       if ("badgeText" in this._changes)
       {
+        // There is no badge on Firefox for Android; the browser action is
+        // simply a menu item.
         if ("setBadgeText" in chrome.browserAction)
         {
           chrome.browserAction.setBadgeText({
             tabId: this._tabId,
             text: this._changes.badgeText
           });
         }
       }
 
       if ("badgeColor" in this._changes)
       {
+        // There is no badge on Firefox for Android; the browser action is
+        // simply a menu item.
         if ("setBadgeBackgroundColor" in chrome.browserAction)
         {
           chrome.browserAction.setBadgeBackgroundColor({
             tabId: this._tabId,
             color: this._changes.badgeColor
           });
         }
       }
 
       this._changes = null;
@@ skipping 379 matching lines @@
   ext.windows = {
     create(createData, callback)
     {
       chrome.windows.create(createData, createdWindow =>
       {
         afterTabLoaded(callback)(createdWindow.tabs[0]);
       });
     }
   };
 }());