Issue 29509576: Issue 5453 - Make website-defaults adblockplus/cms compatible

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29509576: Issue 5453 - Make website-defaults adblockplus/cms compatible (Closed)

Created:
Aug. 8, 2017, 12:43 p.m. by juliandoucette

Modified:
Aug. 8, 2017, 2:16 p.m.

Reviewers:
ire

Base URL:
https://hg.adblockplus.org/website-defaults

Visibility:
Public.

Description

Issue 5453 - Make website-defaults adblockplus/cms compatible COLLABORATOR=i.aderinokun@eyeo.com

Patch Set 1 #

Total comments: 2

Created: Aug. 8, 2017, 12:43 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+258 lines, -358 lines)			Patch
M	.hgignore	View	1 chunk	+1 line, -1 line	0 comments	Download
M	README.md	View	1 chunk	+0 lines, -13 lines	2 comments	Download
R	demo/content.html	View	1 chunk	+0 lines, -102 lines	0 comments	Download
R	demo/css/demo.css	View	1 chunk	+0 lines, -73 lines	0 comments	Download
R	demo/grid.html	View	1 chunk	+0 lines, -108 lines	0 comments	Download
R	demo/index.html	View	1 chunk	+0 lines, -43 lines	0 comments	Download
M	gulpfile.js	View	1 chunk	+2 lines, -15 lines	0 comments	Download
M	package.json	View	1 chunk	+3 lines, -3 lines	0 comments	Download
A	pages/content.html	View	1 chunk	+71 lines, -0 lines	0 comments	Download
A	pages/grid.html	View	1 chunk	+76 lines, -0 lines	0 comments	Download
A	pages/index.html	View	1 chunk	+11 lines, -0 lines	0 comments	Download
A	settings.ini	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	static/css/demo.css	View	1 chunk	+73 lines, -0 lines	0 comments	Download
A	templates/default.tmpl	View	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

juliandoucette

(I also added you as a collaborator) https://codereview.adblockplus.org/29509576/diff/29509577/README.md File README.md (left): https://codereview.adblockplus.org/29509576/diff/29509577/README.md#oldcode5 README.md:5: ## Dependencies ...

Aug. 8, 2017, 1:03 p.m. (2017-08-08 13:03:56 UTC) #2

ire

This doesn't include the static files/includes from website-defaults. Namely: - includes/meta/standard.tmpl - static/scss/main.scss - static/scss/_variables.scss ...

Aug. 8, 2017, 1:12 p.m. (2017-08-08 13:12:46 UTC) #3

ire

https://codereview.adblockplus.org/29509576/diff/29509577/README.md File README.md (left): https://codereview.adblockplus.org/29509576/diff/29509577/README.md#oldcode5 README.md:5: ## Dependencies On 2017/08/08 13:03:55, juliandoucette wrote: > Note: ...

Aug. 8, 2017, 1:13 p.m. (2017-08-08 13:13:28 UTC) #4

LGTM

Expand All Messages | Collapse All Messages