Delta Between Two Patch Sets: pages/forms/advanced.html
Issue 29510560:
Issue 4633 - Default form styles (Closed)
Base URL: https://hg.adblockplus.org/website-defaults
Left Patch Set: Separate forms into basic, advanced, and buttons
Created Aug. 10, 2017, 11:44 a.m.
Right Patch Set: Addressed NITs
Created Sept. 19, 2017, 8:07 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« README.md ('k')
|
pages/forms/basic.html » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 title=Advanced Form Fields | 1 title=Advanced Form Fields |
| 2 | 2 |
| 3 <h1>Advanced Form Fields</h1> | 3 <h1>Advanced Form Fields</h1> |
| 4 <p>Default styles for native form elements.</p> | 4 <p>Default styles for advanced form elements.</p> |
| 5 | |
| 6 <p><a href="forms">Back to Forms</a></p> | |
| 7 | 5 |
| 8 <nav> | 6 <nav> |
| 9 <ol> | 7 <ol> |
| 10 <li><a href="#advanced-text">Advanced text</a></li> | 8 <li><a href="#advanced-text">Advanced text</a></li> |
| 11 <li><a href="#media">Media</a></li> | |
| 12 </ol> | 9 </ol> |
| 13 </nav> | 10 </nav> |
| 14 | 11 |
| 15 <section id="advanced-text"> | 12 <section id="advanced-text"> |
| 16 <h2>Advanced text</h2> | 13 <h2>Advanced text</h2> |
|
juliandoucette
2017/08/10 17:10:06
NIT: We indent by 2 spaces.
ire
2017/08/11 15:25:14
Done.
| |
| 17 <p><input type="search" placeholder="Search terms" /></p> | 14 <p><input type="search" placeholder="Search terms" /></p> |
| 18 <p><input type="tel" placeholder="+55-55-555-5555" /></p> | 15 <p><input type="tel" placeholder="+55-55-555-5555" /></p> |
| 19 <p><input type="url" placeholder="example.com" /></p> | 16 <p><input type="url" placeholder="example.com" /></p> |
| 20 <p><input type="email" placeholder="user@example.com" /></p> | 17 <p><input type="email" placeholder="user@example.com" /></p> |
| 21 <p><input type="password" placeholder="Password" /></p> | 18 <p><input type="password" placeholder="Password" /></p> |
| 22 <p><input type="date" placeholder="Date" /></p> | 19 <p><input type="date" placeholder="Date" /></p> |
| 23 <p><input type="time" placeholder="Time" /></p> | 20 <p><input type="time" placeholder="Time" /></p> |
| 24 <p><input type="datetime-local" placeholder="Datetime Local" /></p> | 21 <p><input type="datetime-local" placeholder="Datetime Local" /></p> |
| 25 <p><input type="number" placeholder="5" /></p> | 22 <p><input type="number" placeholder="5" /></p> |
| 26 </section> | 23 </section> |
| 27 | |
| 28 <section id="advanced-text"> | |
| 29 <h2>Media</h2> | |
| 30 <p> | |
| 31 <label for="file">File</label> | |
| 32 <input id="file" type="file" /> | |
| 33 </p> | |
| 34 </section> | |
| LEFT | RIGHT |
« README.md ('k')
|
pages/forms/basic.html » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
