Issue 4633 - Default form styles

scss/forms/_basic.scss

 /*!
  * This file is part of website-defaults
  * Copyright (C) 2016-2017 eyeo GmbH
  *
  * website-defaults is free software: you can redistribute it and/or
  * modify it under the terms of the GNU General Public License as published by
  * the Free Software Foundation, either version 3 of the License, or
  * (at your option) any later version.
  *
  * website-defaults is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with website-defaults.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /*******************************************************************************
  * Basic forms fields
  *******************************************************************************
  * 1. Reset
  ******************************************************************************/
 
 /* 1. Reset
  ******************************************************************************/
 
+/* Change the font styles in all browsers (opinionated). */
+
 input,
 optgroup,
 select,
 textarea
 {
-  box-sizing: border-box;
-  margin: 0px;

[juliandoucette, 2017/08/24 12:35:24]

NIT: We should mention that this effects Firefox and Safari
[*](https://github.com/necolas/normalize.css/blob/master/normalize.css#L235) and
that the rest of these styles seem to be opinionated.

[ire, 2017/09/13 07:59:57]

Done.

   font: inherit;
 }
 
-/**
- * Show the overflow in IE and Edge
- */
+/* Show the overflow in IE and Edge */
 
 input
 {
   overflow: visible;
 }
 
-/**
- * Remove the inheritance of text transform in Edge, Firefox, and IE.
- */
+/* Remove the inheritance of text transform in Edge, Firefox, and IE. */
 
 select
 {
   text-transform: none;
 }
 
-fieldset,

[juliandoucette, 2017/08/24 12:35:24]

NIT: We should mention that the rest of these styles are opinionated. We should
also test
[this](https://github.com/necolas/normalize.css/commit/cbdd0b1683304ab9132e572dc0a53f927f56d833)
in-case we should display legend as table.

+/* Set block display (opinionated) */
+
+fieldset
+{
+  display: block;
+}
+
+/* Correct the text wrapping in Edge and IE. */
+
 legend
 {
-  display: block;
-  margin: 0px;
-  padding: 0px;

[juliandoucette, 2017/08/24 12:35:24]

NIT: We should mention that this is correcting Firefox
- [*](https://github.com/necolas/normalize.css/blob/master/normalize.css#L311)
- [*](https://github.com/necolas/normalize.css/blob/master/normalize.css#L318)

[ire, 2017/09/13 07:59:57]

No longer relevant with update

-  border: 0px;
+  display: table;
+  max-width: 100%;
+  white-space: normal;
 }
+
+/* Remove the default vertical scrollbar in IE. */
 
 textarea
 {
   overflow: auto;

[juliandoucette, 2017/08/24 12:35:24]

NIT: I think we should mention that this is removing the default scrollbar in IE
[*](https://github.com/necolas/normalize.css/blob/master/normalize.css#L342)

[ire, 2017/09/13 07:59:57]

Done.

 }
 
+/* Remove the padding in IE 10-. */
+
 [type="checkbox"],
 [type="radio"]
 {
   padding: 0px;

[juliandoucette, 2017/08/24 12:35:23]

NIT: I think we should mention that we are removing the padding in IE 10-
[*](https://github.com/necolas/normalize.css/blob/master/normalize.css#L351)

[ire, 2017/09/13 07:59:57]

Done.

 }