Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: scss/forms/_advanced.scss

Issue 29510560: Issue 4633 - Default form styles (Closed) Base URL: https://hg.adblockplus.org/website-defaults
Patch Set: Addressed NITs Created Aug. 11, 2017, 3:23 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scss/forms/_advanced.scss
===================================================================
new file mode 100644
--- /dev/null
+++ b/scss/forms/_advanced.scss
@@ -0,0 +1,64 @@
+/*!
+ * This file is part of website-defaults
+ * Copyright (C) 2016-2017 eyeo GmbH
+ *
+ * website-defaults is free software: you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * website-defaults is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with website-defaults. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+/*******************************************************************************
+ * Adanced forms fields
+ *******************************************************************************
+ * 1. Reset
+ ******************************************************************************/
+
+/* 1. Reset
+ ******************************************************************************/
+
+[type="number"]::-webkit-inner-spin-button,
juliandoucette 2017/08/24 12:35:23 NIT: I think we should mention that we are fixing
ire 2017/09/13 07:59:57 Done.
+[type="number"]::-webkit-outer-spin-button
+{
+ height: auto;
+}
+
+[type="date"],
+[type="time"],
+[type="datetime"],
+[type="datetime-local"],
+[type="month"],
+[type="week"]
juliandoucette 2017/08/24 12:35:23 NIT: These styles seem to differ from normalize.cs
ire 2017/09/13 07:59:57 Done.
+{
+ -webkit-appearance: none;
+}
+
+/**
+ * Use `-webkit-appearance: none` to reset search input in iOS Safari
+ */
+
+[type="search"]
juliandoucette 2017/08/24 12:35:23 NIT: We could add [type="search"] to the previous
ire 2017/09/13 07:59:56 Done.
+{
+ -webkit-appearance: none;
+ outline-offset: -2px;
+}
+
+[type="search"]::-webkit-search-cancel-button,
+[type="search"]::-webkit-search-decoration
juliandoucette 2017/08/24 12:35:23 NIT: We could add these to the previous selector t
ire 2017/09/13 07:59:56 Done.
+{
+ -webkit-appearance: none;
+}
+
+::-webkit-file-upload-button
juliandoucette 2017/08/24 12:35:23 NIT: I Think we should point out what we are doing
ire 2017/09/13 07:59:56 Done.
+{
+ -webkit-appearance: button;
+ font: inherit;
+}

Powered by Google App Engine
This is Rietveld