Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29510583: Issue 5393 - fix libraries order issue when linking of V8 mksnapshot for linux host (Closed)

Created:
Aug. 9, 2017, 12:41 p.m. by sergei
Modified:
Aug. 10, 2017, 1:35 p.m.
Reviewers:
hub
CC:
fhd
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix osx by limiting only for linux #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download
M make_gyp_wrapper.py View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 5
sergei
Aug. 9, 2017, 12:43 p.m. (2017-08-09 12:43:12 UTC) #1
sergei
https://codereview.adblockplus.org/29510583/diff/29510584/make_gyp_wrapper.py File make_gyp_wrapper.py (right): https://codereview.adblockplus.org/29510583/diff/29510584/make_gyp_wrapper.py#newcode122 make_gyp_wrapper.py:122: # replace $(LD_INPUTS) by "-Wl,--start-group $(LD_INPUTS) -Wl,--end-group" but only ...
Aug. 9, 2017, 12:53 p.m. (2017-08-09 12:53:41 UTC) #2
hub
LGTM
Aug. 9, 2017, 12:55 p.m. (2017-08-09 12:55:56 UTC) #3
sergei
It was not working on mac, now it's fixed.
Aug. 10, 2017, 1:29 p.m. (2017-08-10 13:29:01 UTC) #4
hub
Aug. 10, 2017, 1:32 p.m. (2017-08-10 13:32:52 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld