Issue 5347 - Check for contextMenus API support

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 57 matching lines @@
   };
 
   /* Pages */
 
   let Page = ext.Page = function(tab)
   {
     this.id = tab.id;
     this._url = tab.url && new URL(tab.url);
 
     this.browserAction = new BrowserAction(tab.id);
-    this.contextMenus = new ContextMenus(this);
+
+    if (chrome.contextMenus)
+      this.contextMenus = new ContextMenus(this);
   };
   Page.prototype = {
     get url()
     {
       // usually our Page objects are created from Chrome's Tab objects, which
       // provide the url. So we can return the url given in the constructor.
       if (this._url)
         return this._url;
 
       // but sometimes we only have the tab id when we create a Page object.
@@ skipping 322 matching lines @@
 
         if ("color" in badge)
           this._addChange("badgeColor", badge.color);
       }
     }
   };
 
 
   /* Context menus */
 
-  let contextMenuItems = new ext.PageMap();
-  let contextMenuUpdating = false;
+  let ContextMenus = null;
 
-  let updateContextMenu = () =>
+  if (chrome.contextMenus)

[Manish Jethani, 2017/08/10 07:40:05]

Rietveld seems to have messed up the diff. I've only wrapped this code in "if
(chrome.contextMenus)".

   {
-    if (contextMenuUpdating)
-      return;
+    let contextMenuItems = new ext.PageMap();
+    let contextMenuUpdating = false;
 
-    contextMenuUpdating = true;
+    let updateContextMenu = () =>
+    {
+      if (contextMenuUpdating)
+        return;
 
-    chrome.tabs.query({active: true, lastFocusedWindow: true}, tabs =>
-    {
-      chrome.contextMenus.removeAll(() =>
+      contextMenuUpdating = true;
+
+      chrome.tabs.query({active: true, lastFocusedWindow: true}, tabs =>
       {
-        contextMenuUpdating = false;
+        chrome.contextMenus.removeAll(() =>
+        {
+          contextMenuUpdating = false;
 
-        if (tabs.length == 0)
-          return;
+          if (tabs.length == 0)
+            return;
 
-        let items = contextMenuItems.get({id: tabs[0].id});
+          let items = contextMenuItems.get({id: tabs[0].id});
 
-        if (!items)
-          return;
+          if (!items)
+            return;
 
-        items.forEach(item =>
-        {
-          chrome.contextMenus.create({
-            title: item.title,
-            contexts: item.contexts,
-            onclick(info, tab)
-            {
-              item.onclick(new Page(tab));
-            }
+          items.forEach(item =>
+          {
+            chrome.contextMenus.create({
+              title: item.title,
+              contexts: item.contexts,
+              onclick(info, tab)
+              {
+                item.onclick(new Page(tab));
+              }
+            });
           });
         });
       });
-    });
-  };
+    };
 
-  let ContextMenus = function(page)
-  {
-    this._page = page;
-  };
-  ContextMenus.prototype = {
-    create(item)
+    ContextMenus = function(page)
     {
-      let items = contextMenuItems.get(this._page);
-      if (!items)
-        contextMenuItems.set(this._page, items = []);
+      this._page = page;
+    };
+    ContextMenus.prototype = {
+      create(item)
+      {
+        let items = contextMenuItems.get(this._page);
+        if (!items)
+          contextMenuItems.set(this._page, items = []);
 
-      items.push(item);
-      updateContextMenu();
-    },
-    remove(item)
-    {
-      let items = contextMenuItems.get(this._page);
-      if (items)
+        items.push(item);
+        updateContextMenu();
+      },
+      remove(item)
       {
-        let index = items.indexOf(item);
-        if (index != -1)
+        let items = contextMenuItems.get(this._page);
+        if (items)
         {
-          items.splice(index, 1);
-          updateContextMenu();
+          let index = items.indexOf(item);
+          if (index != -1)
+          {
+            items.splice(index, 1);
+            updateContextMenu();
+          }
         }
       }
-    }
-  };
+    };
 
-  chrome.tabs.onActivated.addListener(updateContextMenu);
+    chrome.tabs.onActivated.addListener(updateContextMenu);
 
-  chrome.windows.onFocusChanged.addListener(windowId =>
-  {
-    if (windowId != chrome.windows.WINDOW_ID_NONE)
-      updateContextMenu();
-  });
+    chrome.windows.onFocusChanged.addListener(windowId =>
+    {
+      if (windowId != chrome.windows.WINDOW_ID_NONE)
+        updateContextMenu();
+    });
+  }
 
 
   /* Web requests */
 
   let framesOfTabs = new Map();
 
   ext.getFrame = (tabId, frameId) =>
   {
     let frames = framesOfTabs.get(tabId);
     return frames && frames.get(frameId);
@@ skipping 233 matching lines @@
   ext.windows = {
     create(createData, callback)
     {
       chrome.windows.create(createData, createdWindow =>
       {
         afterTabLoaded(callback)(createdWindow.tabs[0]);
       });
     }
   };
 }());