hiera/roles/filterserver.yaml - Issue 29511584: #2762 - Fix provisioning of geoip to filter servers

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: hiera/roles/filterserver.yaml

Issue 29511584: #2762 - Fix provisioning of geoip to filter servers (Closed) Base URL: https://hg1/infrastructure

Left Patch Set: Created Aug. 10, 2017, 9:57 a.m.

Right Patch Set: split the absent package into a legacy class Created Aug. 11, 2017, 12:37 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 classes:	1 classes:

2 filterserver:	2 filterserver:

3 is_default: true	3 is_default: true

4 notificationserver:	4 notificationserver:

5 is_default: false	5 is_default: false

6 geoip:	6 geoip:
	mathias 2017/08/14 08:04:33 Since class filterserver depends on class geoip it Since class filterserver depends on class geoip it should include the latter.
	7 adblockplus::legacy::filterserver:
	mathias 2017/08/14 08:04:33 This class should in turn include class filterserv This class should in turn include class filterserver, it's basically the adapter for the legacy module. You can use a root-level `filterserver::is_default: true` to replace the parametrization above.
7	8

8 # http://hub.eyeo.com/issues/1981	9 # http://hub.eyeo.com/issues/1981

9 nginx::worker_connections: 4000	10 nginx::worker_connections: 4000

10 nginx::ssl_session_cache: off	11 nginx::ssl_session_cache: off

11	12

12 # http://hub.eyeo.com/issues/1990	13 # http://hub.eyeo.com/issues/1990

13 nginx::modules:	14 nginx::modules:

14 geoip:	15 geoip:

15 name: "ngx_http_geoip_module.so"	16 name: "ngx_http_geoip_module.so"

16	17

LEFT	RIGHT