Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29511621: Noissue - fix the value of gyp -Gandroid_ndk_version parameter in accordance to the used Android NDK (Closed)

Created:
Aug. 10, 2017, 1:43 p.m. by sergei
Modified:
Aug. 10, 2017, 2:08 p.m.
Reviewers:
anton, hub
CC:
Felix Dahlke
Base URL:
https://github.com/adblockplus/libadblockplus.git
Visibility:
Public.

Description

The value of this parameter is not actually used, though, gyp merely checks whether it's set or not. Review: https://codereview.adblockplus.org/29511621/

Patch Set 1 #

Total comments: 2

Patch Set 2 : add 'r' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Makefile View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
sergei
Aug. 10, 2017, 1:44 p.m. (2017-08-10 13:44:25 UTC) #1
anton
https://codereview.adblockplus.org/29511621/diff/29511622/Makefile File Makefile (right): https://codereview.adblockplus.org/29511621/diff/29511622/Makefile#newcode127 Makefile:127: python ./make_gyp_wrapper.py --depth=. -f make-android -Ilibadblockplus.gypi --generator-output=build -Gandroid_ndk_version=12b libadblockplus.gyp ...
Aug. 10, 2017, 1:47 p.m. (2017-08-10 13:47:10 UTC) #2
sergei
https://codereview.adblockplus.org/29511621/diff/29511622/Makefile File Makefile (right): https://codereview.adblockplus.org/29511621/diff/29511622/Makefile#newcode127 Makefile:127: python ./make_gyp_wrapper.py --depth=. -f make-android -Ilibadblockplus.gypi --generator-output=build -Gandroid_ndk_version=12b libadblockplus.gyp ...
Aug. 10, 2017, 1:51 p.m. (2017-08-10 13:51:06 UTC) #3
anton
On 2017/08/10 13:51:06, sergei wrote: > https://codereview.adblockplus.org/29511621/diff/29511622/Makefile > File Makefile (right): > > https://codereview.adblockplus.org/29511621/diff/29511622/Makefile#newcode127 > ...
Aug. 10, 2017, 1:51 p.m. (2017-08-10 13:51:39 UTC) #4
hub
Aug. 10, 2017, 2:08 p.m. (2017-08-10 14:08:13 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld