Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1856)

Issue 29511670: Issue 5446 - Add missing essential meta data to adblockbrowser.org (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by juliandoucette
Modified:
2 months ago
Reviewers:
saroyanm, ire
Base URL:
https://hg.adblockplus.org/web.adblockbrowser.org
Visibility:
Public.

Description

Issue 5446 - Add missing essential meta data to adblockbrowser.org

Patch Set 1 #

Patch Set 2 : Re-added index page description and matched previous description string id #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -7 lines) Patch
A filters/to_og_locale.py View 1 chunk +33 lines, -0 lines 0 comments Download
M pages/index.tmpl View 1 1 chunk +1 line, -4 lines 0 comments Download
M settings.ini View 1 chunk +2 lines, -1 line 0 comments Download
M templates/default.tmpl View 1 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 3
juliandoucette
2 months, 1 week ago (2017-08-10 19:11:52 UTC) #1
ire
LGTM NIT: I think the comments you left on the other sites (e.g. HTML5 essentials, ...
2 months, 1 week ago (2017-08-11 09:02:52 UTC) #2
juliandoucette
2 months, 1 week ago (2017-08-12 17:14:51 UTC) #3
On 2017/08/11 09:02:52, ire wrote:
> NIT: I think the comments you left on the other sites (e.g. HTML5 essentials,
> HTML5 meta) were helpful and can be included here.

Ack. These will be included in the website-defaults includes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5