Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(365)

Issue 29511691: Issue 5444 - Add missing essential meta data to eyeo.com (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by juliandoucette
Modified:
3 months, 4 weeks ago
Reviewers:
saroyanm, ire
Base URL:
https://hg.adblockplus.org/web.eyeo.com
Visibility:
Public.

Description

Issue 5444 - Add missing essential meta data to eyeo.com

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -8 lines) Patch
A filters/to_og_locale.py View 1 chunk +33 lines, -0 lines 0 comments Download
M settings.ini View 1 chunk +1 line, -0 lines 0 comments Download
M templates/default.tmpl View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3
juliandoucette
4 months ago (2017-08-10 20:04:26 UTC) #1
juliandoucette
Note: I tested the generation script and it didn't throw an error as a result ...
4 months ago (2017-08-10 20:08:09 UTC) #2
ire
4 months ago (2017-08-11 08:45:15 UTC) #3
On 2017/08/10 20:08:09, juliandoucette wrote:
> Note: I tested the generation script and it didn't throw an error as a result
of
> missing a title on a page. This is relevant because I made title required in
my
> Patchset.

Ack.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5