filters/ignore_browsers.py - Issue 29511696: Issue 5447 - Add missing essential meta data to adblockplus.org

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: filters/ignore_browsers.py

Issue 29511696: Issue 5447 - Add missing essential meta data to adblockplus.org (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org

Patch Set: Added ignore_browsers filter Created Aug. 15, 2017, 5:10 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 browsers = [

	2 "opera",

	3 "firefox",

	4 "yandex-browser",

	5 "android",

	6 "safari",

	7 "maxthon",

	8 "edge",

	9 "chrome",

	10 "internet-explorer",

	11 ]
	Thomas Greiner 2017/08/17 12:27:36 That is a valid approach if we could ensure that n That is a valid approach if we could ensure that newly added home page variants are also being added here. Alternatively, what do you think about some kind of URL path override? That way we could ensure that every home page variant will point to a single URL while still using `get_canonical_url()` to avoid having to hardcode the entire URL in the template. e.g. title=Adblock Plus - Surf the web without annoying ads! noheading=True localefile=index canonical=/ This approach could also be used in the future if we want to publish the same content across multiple websites or duplicate some other content on our website. (e.g. Acceptable Ads criteria, blog posts, etc.) What do you think? juliandoucette 2017/08/17 13:50:07 I think that is a good idea and it should be imple Show quoted text On 2017/08/17 12:27:36, Thomas Greiner wrote: > That is a valid approach if we could ensure that newly added home page variants > are also being added here. > > Alternatively, what do you think about some kind of URL path override? That way > we could ensure that every home page variant will point to a single URL while > still using `get_canonical_url()` to avoid having to hardcode the entire URL in > the template. > > e.g. > title=Adblock Plus - Surf the web without annoying ads! > noheading=True > localefile=index > canonical=/ > > This approach could also be used in the future if we want to publish the same > content across multiple websites or duplicate some other content on our website. > (e.g. Acceptable Ads criteria, blog posts, etc.) > > What do you think? I think that is a good idea and it should be implemented in get_canonical_url instead of a separate filter.
	12

	13 def ignore_browsers(page):

	14 if page in browsers:

	15 return "index"

	16 else:

	17 return page

OLD	NEW

« no previous file with comments | « no previous file | filters/to_og_locale.py » ('j') | no next file with comments »