Issue 5447 - Add missing essential meta data to adblockplus.org

filters/ignore_browsers.py

Index: filters/ignore_browsers.py
===================================================================
new file mode 100644
--- /dev/null
+++ b/filters/ignore_browsers.py
@@ -0,0 +1,17 @@
+browsers = [
+    "opera",
+    "firefox",
+    "yandex-browser",
+    "android",
+    "safari",
+    "maxthon",
+    "edge",
+    "chrome",
+    "internet-explorer",
+]

[Thomas Greiner, 2017/08/17 12:27:36]

That is a valid approach if we could ensure that newly added home page variants
are also being added here.

Alternatively, what do you think about some kind of URL path override? That way
we could ensure that every home page variant will point to a single URL while
still using `get_canonical_url()` to avoid having to hardcode the entire URL in
the template.

e.g.
title=Adblock Plus - Surf the web without annoying ads!
noheading=True
localefile=index
canonical=/

This approach could also be used in the future if we want to publish the same
content across multiple websites or duplicate some other content on our website.
(e.g. Acceptable Ads criteria, blog posts, etc.)

What do you think?

[juliandoucette, 2017/08/17 13:50:07]

I think that is a good idea and it should be implemented in get_canonical_url
instead of a separate filter.

+
+def ignore_browsers(page):
+    if page in browsers:
+        return "index"
+    else:
+        return page