Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(748)

Issue 29512597: Issue 4491 - Adds handling for block commented page metadata (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by Jon Sonesen
Modified:
2 months ago
Reviewers:
Vasily Kuznetsov
Visibility:
Public.

Description

Issue 4491 - Adds handling for block commented page metadata

Patch Set 1 #

Total comments: 2

Patch Set 2 : add strip call to line check #

Total comments: 1

Patch Set 3 : ;) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M cms/converters.py View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Jon Sonesen
2 months, 1 week ago (2017-08-11 08:36:11 UTC) #1
Vasily Kuznetsov
Hi Jon, Looks pretty good. Just one suggestion: https://codereview.adblockplus.org/29512597/diff/29512598/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29512597/diff/29512598/cms/converters.py#newcode125 cms/converters.py:125: if ...
2 months, 1 week ago (2017-08-11 17:38:22 UTC) #2
Jon Sonesen
Thanks for looking! How's this? https://codereview.adblockplus.org/29512597/diff/29512598/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29512597/diff/29512598/cms/converters.py#newcode125 cms/converters.py:125: if line == '<!--\n' ...
2 months, 1 week ago (2017-08-14 05:58:52 UTC) #3
Vasily Kuznetsov
LGTM https://codereview.adblockplus.org/29512597/diff/29515555/cms/converters.py File cms/converters.py (right): https://codereview.adblockplus.org/29512597/diff/29515555/cms/converters.py#newcode125 cms/converters.py:125: if line.strip() == '<!--' or line.strip() == '-->': ...
2 months, 1 week ago (2017-08-14 11:20:07 UTC) #4
Jon Sonesen
2 months ago (2017-08-15 10:45:25 UTC) #5
;)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5