Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(692)

Issue 29513555: Issue 5512 - Manage multiple notifications displayed at the same time

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months, 1 week ago by Manish Jethani
Modified:
2 months, 1 week ago
Reviewers:
kzar
CC:
Sebastian Noack, Thomas Greiner
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 5512 - Manage multiple notifications displayed at the same time

Patch Set 1 #

Total comments: 14
Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -46 lines) Patch
M lib/notificationHelper.js View 2 chunks +121 lines, -45 lines 14 comments Download
M notification.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8
Manish Jethani
11 months, 1 week ago (2017-08-12 16:49:13 UTC) #1
Manish Jethani
Patch Set 1 Comments inline. https://codereview.adblockplus.org/29513555/diff/29513556/lib/notificationHelper.js File lib/notificationHelper.js (left): https://codereview.adblockplus.org/29513555/diff/29513556/lib/notificationHelper.js#oldcode139 lib/notificationHelper.js:139: activeNotification.onClicked(); Calling onClicked (now ...
11 months, 1 week ago (2017-08-12 16:57:48 UTC) #2
kzar
(Adding Thomas to Cc.) https://codereview.adblockplus.org/29513555/diff/29513556/lib/notificationHelper.js File lib/notificationHelper.js (right): https://codereview.adblockplus.org/29513555/diff/29513556/lib/notificationHelper.js#newcode29 lib/notificationHelper.js:29: // "Open" notifications are any ...
11 months ago (2017-08-21 13:59:25 UTC) #3
Thomas Greiner
https://codereview.adblockplus.org/29513555/diff/29513556/lib/notificationHelper.js File lib/notificationHelper.js (right): https://codereview.adblockplus.org/29513555/diff/29513556/lib/notificationHelper.js#newcode260 lib/notificationHelper.js:260: // Critical notifications should not go away in a ...
11 months ago (2017-08-22 18:17:00 UTC) #4
Manish Jethani
https://codereview.adblockplus.org/29513555/diff/29513556/lib/notificationHelper.js File lib/notificationHelper.js (right): https://codereview.adblockplus.org/29513555/diff/29513556/lib/notificationHelper.js#newcode49 lib/notificationHelper.js:49: function prepareNotificationIconAndPopup(notification) On 2017/08/21 13:59:24, kzar wrote: > Since ...
10 months, 4 weeks ago (2017-08-24 09:54:12 UTC) #5
Manish Jethani
https://codereview.adblockplus.org/29513555/diff/29513556/lib/notificationHelper.js File lib/notificationHelper.js (right): https://codereview.adblockplus.org/29513555/diff/29513556/lib/notificationHelper.js#newcode49 lib/notificationHelper.js:49: function prepareNotificationIconAndPopup(notification) On 2017/08/21 13:59:24, kzar wrote: > Since ...
10 months, 4 weeks ago (2017-08-24 09:54:12 UTC) #6
kzar
https://codereview.adblockplus.org/29513555/diff/29513556/lib/notificationHelper.js File lib/notificationHelper.js (right): https://codereview.adblockplus.org/29513555/diff/29513556/lib/notificationHelper.js#newcode260 lib/notificationHelper.js:260: // Critical notifications should not go away in a ...
10 months, 3 weeks ago (2017-08-29 12:16:30 UTC) #7
kzar_kzar.co.uk
2 months, 1 week ago (2018-05-09 10:31:21 UTC) #8

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5