Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29515617: Issue 5517 - Update README.md with build changes required by 45.0.2 merge (Closed)

Created:
Aug. 14, 2017, 10:43 p.m. by diegocarloslima
Modified:
Aug. 16, 2017, 1:34 p.m.
Reviewers:
anton, jens
CC:
Felix Dahlke, René Jeschke
Visibility:
Public.

Description

Issue 5517 - Update README.md with build changes required by 45.0.2 merge

Patch Set 1 #

Total comments: 2

Patch Set 2 : Adding https to adblockbrowser-build link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M README.md View 1 4 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 5
diegocarloslima
Aug. 14, 2017, 10:43 p.m. (2017-08-14 22:43:56 UTC) #1
jens
https://codereview.adblockplus.org/29515617/diff/29515618/README.md File README.md (right): https://codereview.adblockplus.org/29515617/diff/29515618/README.md#newcode129 README.md:129: [2]: hg.adblockplus.org/adblockbrowser-build/ minor one, but you could add https://
Aug. 15, 2017, 1:38 p.m. (2017-08-15 13:38:21 UTC) #2
diegocarloslima
https://codereview.adblockplus.org/29515617/diff/29515618/README.md File README.md (right): https://codereview.adblockplus.org/29515617/diff/29515618/README.md#newcode129 README.md:129: [2]: hg.adblockplus.org/adblockbrowser-build/ On 2017/08/15 13:38:21, jens wrote: > minor ...
Aug. 15, 2017, 2:04 p.m. (2017-08-15 14:04:42 UTC) #3
anton
On 2017/08/15 14:04:42, diegocarloslima wrote: > https://codereview.adblockplus.org/29515617/diff/29515618/README.md > File README.md (right): > > https://codereview.adblockplus.org/29515617/diff/29515618/README.md#newcode129 > ...
Aug. 16, 2017, 1:12 p.m. (2017-08-16 13:12:08 UTC) #4
jens
Aug. 16, 2017, 1:12 p.m. (2017-08-16 13:12:15 UTC) #5
On 2017/08/15 14:04:42, diegocarloslima wrote:
> https://codereview.adblockplus.org/29515617/diff/29515618/README.md
> File README.md (right):
> 
> https://codereview.adblockplus.org/29515617/diff/29515618/README.md#newcode129
> README.md:129: [2]: hg.adblockplus.org/adblockbrowser-build/
> On 2017/08/15 13:38:21, jens wrote:
> > minor one, but you could add https://
> 
> Acknowledged.

LGTM

Powered by Google App Engine
This is Rietveld