Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(208)

Issue 29516569: Issue 5347 - Check for windows API support (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by Manish Jethani
Modified:
2 years ago
Reviewers:
Sebastian Noack
CC:
Wladimir Palant
Base URL:
https://hg.adblockplus.org/adblockpluschrome/
Visibility:
Public.

Description

Issue 5347 - Check for windows API support

Patch Set 1 #

Total comments: 6

Patch Set 2 : Remove check for ext.windows #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -8 lines) Patch
M ext/background.js View 1 2 2 chunks +25 lines, -8 lines 0 comments Download

Messages

Total messages: 9
Manish Jethani
2 years, 1 month ago (2017-08-15 14:08:53 UTC) #1
Manish Jethani
We need to add these checks for Firefox for Android. In addition to this, the ...
2 years, 1 month ago (2017-08-15 14:11:16 UTC) #2
Sebastian Noack
On 2017/08/15 14:11:16, Manish Jethani wrote: > In addition to this, the code in composer.postload.js ...
2 years, 1 month ago (2017-08-15 14:40:19 UTC) #3
Manish Jethani
On 2017/08/15 14:40:19, Sebastian Noack wrote: > On 2017/08/15 14:11:16, Manish Jethani wrote: > > ...
2 years, 1 month ago (2017-08-15 16:23:57 UTC) #4
Manish Jethani
https://codereview.adblockplus.org/29516569/diff/29516570/ext/background.js File ext/background.js (left): https://codereview.adblockplus.org/29516569/diff/29516570/ext/background.js#oldcode699 ext/background.js:699: // Edge does not yet support runtime.openOptionsPage (tested version ...
2 years, 1 month ago (2017-08-15 16:24:12 UTC) #5
Sebastian Noack
https://codereview.adblockplus.org/29516569/diff/29516570/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29516569/diff/29516570/ext/background.js#newcode751 ext/background.js:751: ext.windows = { On 2017/08/15 16:24:12, Manish Jethani wrote: ...
2 years, 1 month ago (2017-08-18 10:25:22 UTC) #6
Manish Jethani
Patch Set 2: Remove check for ext.windows https://codereview.adblockplus.org/29516569/diff/29516570/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29516569/diff/29516570/ext/background.js#newcode751 ext/background.js:751: ext.windows = ...
2 years, 1 month ago (2017-08-18 14:09:58 UTC) #7
Manish Jethani
Patch Set 3: Rebase
2 years ago (2017-08-23 14:18:05 UTC) #8
Sebastian Noack
2 years ago (2017-08-24 10:49:13 UTC) #9
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5