Issue 5347 - Check for windows API support

ext/background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-2017 eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 470 matching lines @@
         {
           items.splice(index, 1);
           updateContextMenu();
         }
       }
     }
   };
 
   chrome.tabs.onActivated.addListener(updateContextMenu);
 
-  chrome.windows.onFocusChanged.addListener(windowId =>
+  if ("windows" in chrome)
   {
-    if (windowId != chrome.windows.WINDOW_ID_NONE)
-      updateContextMenu();
-  });
+    chrome.windows.onFocusChanged.addListener(windowId =>
+    {
+      if (windowId != chrome.windows.WINDOW_ID_NONE)
+        updateContextMenu();
+    });
+  }
 
 
   /* Web requests */
 
   let framesOfTabs = new Map();
 
   ext.getFrame = (tabId, frameId) =>
   {
     let frames = framesOfTabs.get(tabId);
     return frames && frames.get(frameId);
@@ skipping 190 matching lines @@
   }
   else
   {
     // Edge does not yet support runtime.openOptionsPage (tested version 38)
     // and so this workaround needs to stay for now.
     // We are not using extension.getURL to get the absolute path here
     // because of the Edge issue:
     // https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10276332/
     ext.showOptions = callback =>
     {
-      chrome.windows.getLastFocused(win =>
+      let optionsUrl = "options.html";
+      let queryInfo = {url: optionsUrl};
+
+      let open = win =>
       {
-        let optionsUrl = "options.html";
-        let queryInfo = {url: optionsUrl};
-
         // extension pages can't be accessed in incognito windows. In order to
         // correctly mimic the way in which Chrome opens extension options,
         // we have to focus the options page in any other window.
-        if (!win.incognito)
+        if (win && !win.incognito)
           queryInfo.windowId = win.id;
 
         chrome.tabs.query(queryInfo, tabs =>
         {
           if (tabs.length > 0)
           {
             let tab = tabs[0];
 
-            chrome.windows.update(tab.windowId, {focused: true});
+            if ("windows" in chrome)
+              chrome.windows.update(tab.windowId, {focused: true});
+
             chrome.tabs.update(tab.id, {active: true});
 
             if (callback)
               callback(new Page(tab));
           }
           else
           {
             ext.pages.open(optionsUrl, callback);
           }
         });
-      });
+      };
+
+      if ("windows" in chrome)
+        chrome.windows.getLastFocused(open);
+      else
+        open();
     };
   }
 
   /* Windows */
   ext.windows = {
     create(createData, callback)
     {
       chrome.windows.create(createData, createdWindow =>
       {
         afterTabLoaded(callback)(createdWindow.tabs[0]);
       });
     }
   };
 }());