globals/products.py - Issue 29516622: Issue 5511 - Create Product Help Home Template for help.eyeo.com

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: globals/products.py

Issue 29516622: Issue 5511 - Create Product Help Home Template for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com

Patch Set: Created Aug. 15, 2017, 3:01 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

« globals/get_page_slug.py ('K') | « globals/get_page_slug.py ('k') | pages/adblockplus/adblock-plus-breaks-the-websites-i-visit.md » ('j') | pages/adblockplus/adblock-plus-breaks-the-websites-i-visit.md » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # This file is part of help.eyeo.com.

	2 # Copyright [C] 2016 Eyeo GmbH

	3 #

	4 # help.eyeo.com is free software: you can redistribute it and/or modify

	5 # it under the terms of the GNU General Public License as published by

	6 # the Free Software Foundation, either version 3 of the License, or

	7 # [at your option] any later version.

	8 #

	9 # help.eyeo.com is distributed in the hope that it will be useful,

	10 # but WITHOUT ANY WARRANTY; without even the implied warranty of

	11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

	12 # GNU General Public License for more details.

	13 #

	14 # You should have received a copy of the GNU General Public License

	15 # along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.

	16

	17 products = {

	18 "abp": {

	19 "full_name": "Adblock Plus",

	20 "url": "https://adblockplus.org",

	21 "help_categories": [
	juliandoucette 2017/08/24 11:13:59 I think that we want to avoid hard coding things l I think that we want to avoid hard coding things like this if possible. e.g. Instead of looping products[product]['help_categories'] we could loop get_pages_metadata({product: product}) sorted by category (by sorting it ourselves or requesting that Sitescripts adds a sort feature to get_pages_metadata). ire 2017/08/28 14:54:47 I agree with you, I think this should be included Show quoted text On 2017/08/24 11:13:59, juliandoucette wrote: > I think that we want to avoid hard coding things like this if possible. > > e.g. Instead of looping products[product]['help_categories'] we could loop > get_pages_metadata({product: product}) sorted by category (by sorting it > ourselves or requesting that Sitescripts adds a sort feature to > get_pages_metadata). I agree with you, I think this should be included in get_pages_metadata I'm unsure how to deal with the icons though. If we don't have a single reference for them being tied to categories here, we wouldn't be able to just loop through the categories like we are doing now. Any ideas? juliandoucette 2017/09/12 13:21:52 See my comment in the latest patchset. Show quoted text On 2017/08/28 14:54:47, ire wrote: > On 2017/08/24 11:13:59, juliandoucette wrote: > > I think that we want to avoid hard coding things like this if possible. > > > > e.g. Instead of looping products[product]['help_categories'] we could loop > > get_pages_metadata({product: product}) sorted by category (by sorting it > > ourselves or requesting that Sitescripts adds a sort feature to > > get_pages_metadata). > > I agree with you, I think this should be included in get_pages_metadata > > I'm unsure how to deal with the icons though. If we don't have a single > reference for them being tied to categories here, we wouldn't be able to just > loop through the categories like we are doing now. Any ideas? See my comment in the latest patchset.
	22 {

	23 "name": "Popular Topics",

	24 "slug": "popular-topics",

	25 "icon": "popular-icon"

	26 },

	27 {

	28 "name": "Customization & Settings",

	29 "slug": "customization-and-settings",

	30 "icon": "settings-icon"

	31 },

	32 {

	33 "name": "Troubleshooting & Reporting",

	34 "slug": "troubleshooting-and-reporting",

	35 "icon": "reporting-icon"

	36 },

	37 {

	38 "name": "Installation",

	39 "slug": "installation",

	40 "icon": "install-icon"

	41 },

	42 {

	43 "name": "Adblock Plus for Mobile",

	44 "slug": "abp-for-mobile",

	45 "icon": "mobile-icon"

	46 }

	47 ]

	48 }

	49 }

OLD	NEW