Issue 5511 - Create Product Help Home Template for help.eyeo.com

static/scss/components/_lists.scss

+// This file is part of help.eyeo.com.
+// Copyright (C) 2017 Eyeo GmbH
+//
+// help.eyeo.com is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// help.eyeo.com is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with help.eyeo.com.  If not, see <http://www.gnu.org/licenses/>.
+
+// Underlined Lists //////////////////////////////////////////////////////////////////////
+
+.underlined-list
+{
+  list-style: none;
+}
+
+.underlined-list li a

[juliandoucette, 2017/08/24 11:14:00]

NIT: I think that the line should be under the <li> because the <a> may have
text-decoration (now or later) and it seems more modular to me. This is a little
subjective; obviously :/ . You may disagree.

[ire, 2017/08/28 14:54:48]

I agree, I initially did it this way actually, but it didn't really work out
because the <li> has the `.one-half` class, which applies padding to both sides
to create the space. If the <li> was underlined, there would be no spacing
between each of the items. 

[juliandoucette, 2017/09/12 13:21:53]

Acknowledged.

+{
+  display: block;
+  width: 100%;

[juliandoucette, 2017/08/24 11:14:00]

NIT: Is this necessary because display:block?

[ire, 2017/08/28 14:54:48]

Done.

+  padding-top: $sm;
+  padding-bottom: $sm;
+  border-bottom: 1px dotted $gray;
+}
+
+
+.underlined-list li:last-child a
+{
+  border-bottom: none;
+}
+
+.underlined-list .one-half:nth-child(1) a

[juliandoucette, 2017/08/24 11:13:59]

Why is this necessary?

The same applies below.

[ire, 2017/08/28 14:54:48]

All of the list items typically have a border-bottom. With <li> items like the
popular topics one that are displayed in two columns, the first item has a
border-top as well. The media queries are because, the columns collapse into one
on smaller screens, so only the first list item needs the border-top until a
certain viewport width

[juliandoucette, 2017/09/12 13:21:53]

Acknowledged.

[juliandoucette, 2017/09/22 13:49:13]

Can you add a comment about this?

[ire, 2017/09/25 07:25:26]

Done.

+{
+  border-top: 1px dotted $gray;
+}
+
+.underlined-list .one-half:nth-child(2) a
+{
+  @media (min-width: $tablet-breakpoint)
+  {
+    border-top: 1px dotted $gray;
+  }
+}