Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: static/scss/layout/_body.scss

Issue 29516622: Issue 5511 - Create Product Help Home Template for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Created Aug. 15, 2017, 3:01 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 // This file is part of help.eyeo.com. 1 // This file is part of help.eyeo.com.
2 // Copyright (C) 2017 Eyeo GmbH 2 // Copyright (C) 2017 Eyeo GmbH
3 // 3 //
4 // help.eyeo.com is free software: you can redistribute it and/or modify 4 // help.eyeo.com is free software: you can redistribute it and/or modify
5 // it under the terms of the GNU General Public License as published by 5 // it under the terms of the GNU General Public License as published by
6 // the Free Software Foundation, either version 3 of the License, or 6 // the Free Software Foundation, either version 3 of the License, or
7 // (at your option) any later version. 7 // (at your option) any later version.
8 // 8 //
9 // help.eyeo.com is distributed in the hope that it will be useful, 9 // help.eyeo.com is distributed in the hope that it will be useful,
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of
11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 // GNU General Public License for more details. 12 // GNU General Public License for more details.
13 // 13 //
14 // You should have received a copy of the GNU General Public License 14 // You should have received a copy of the GNU General Public License
15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>. 15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.
16 16
17 .outer 17 .outer
18 { 18 {
19 min-height: 100vh; // For testing purposes. Will remove.
20 margin-top: $site-header-height; 19 margin-top: $site-header-height;
20 background-image: url("/img/png/help-bg.png");
juliandoucette 2017/08/24 11:14:01 NIT: Apparently our code style guide suggests no q
ire 2017/08/28 14:54:49 Oh okay. I thought it was the other way around, I
juliandoucette 2017/09/12 13:21:53 That's probably my fault :D (or, at least, you can
21 background-repeat: no-repeat;
21 } 22 }
23
24 .main
juliandoucette 2017/08/24 11:14:00 NIT: Isn't there usually only one <main> or #main?
ire 2017/08/28 14:54:49 Changed to #main
25 {
26 padding-top: $lg;
27 padding-bottom: $xl;
28
29 @media (min-width: $mobile-breakpoint)
30 {
31 padding-top: $xl;
32 }
33 }
34
35 .wrapper
juliandoucette 2017/08/24 11:14:01 NIT: If you agree with my comment about .nav-wrapp
ire 2017/08/28 14:54:48 Okay, I think it makes sense to update this when t
36 {
37 width: $content-width;
38 max-width: $content-max-width;
39 margin-right: auto;
40 margin-left: auto;
41 }
42
43 .section
44 {
45 margin-bottom: $lg;
46
47 @media (min-width: $mobile-breakpoint)
48 {
49 margin-bottom: $xl;
50 }
51 }
OLDNEW

Powered by Google App Engine
This is Rietveld