Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/scss/components/_lists.scss

Issue 29516622: Issue 5511 - Create Product Help Home Template for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Left Patch Set: Created Aug. 15, 2017, 3:01 p.m.
Right Patch Set: Addressed final NITs Created Sept. 25, 2017, 7:24 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/scss/components/_card.scss ('k') | static/scss/content/_typography.scss » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 // This file is part of help.eyeo.com. 1 // This file is part of help.eyeo.com.
2 // Copyright (C) 2017 Eyeo GmbH 2 // Copyright (C) 2017 Eyeo GmbH
3 // 3 //
4 // help.eyeo.com is free software: you can redistribute it and/or modify 4 // help.eyeo.com is free software: you can redistribute it and/or modify
5 // it under the terms of the GNU General Public License as published by 5 // it under the terms of the GNU General Public License as published by
6 // the Free Software Foundation, either version 3 of the License, or 6 // the Free Software Foundation, either version 3 of the License, or
7 // (at your option) any later version. 7 // (at your option) any later version.
8 // 8 //
9 // help.eyeo.com is distributed in the hope that it will be useful, 9 // help.eyeo.com is distributed in the hope that it will be useful,
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of
11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 // GNU General Public License for more details. 12 // GNU General Public License for more details.
13 // 13 //
14 // You should have received a copy of the GNU General Public License 14 // You should have received a copy of the GNU General Public License
15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>. 15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.
16 16
17 // Underlined Lists //////////////////////////////////////////////////////////// ////////// 17 // Underlined Lists //////////////////////////////////////////////////////////// //////////
18 18
19 .underlined-list 19 .underlined-list
20 { 20 {
21 list-style: none; 21 list-style: none;
22 } 22 }
23 23
24 .underlined-list li a 24 .underlined-list li a
juliandoucette 2017/08/24 11:14:00 NIT: I think that the line should be under the <li
ire 2017/08/28 14:54:48 I agree, I initially did it this way actually, but
juliandoucette 2017/09/12 13:21:53 Acknowledged.
25 { 25 {
26 display: block; 26 display: block;
27 width: 100%;
juliandoucette 2017/08/24 11:14:00 NIT: Is this necessary because display:block?
ire 2017/08/28 14:54:48 Done.
28 padding-top: $sm; 27 padding-top: $sm;
29 padding-bottom: $sm; 28 padding-bottom: $sm;
30 border-bottom: 1px dotted $gray; 29 border-bottom: 1px dotted $gray;
30 color: $accent;
31 } 31 }
32
33 32
34 .underlined-list li:last-child a 33 .underlined-list li:last-child a
35 { 34 {
36 border-bottom: none; 35 border-bottom: none;
37 } 36 }
37
38 // For underlined lists split into two columns, add a border-top
39 // to the first 2 children on larger screens, and only the first
40 // child on smaller screens (when collapsed to one column)
38 41
39 .underlined-list .one-half:nth-child(1) a 42 .underlined-list .one-half:nth-child(1) a
juliandoucette 2017/08/24 11:13:59 Why is this necessary? The same applies below.
ire 2017/08/28 14:54:48 All of the list items typically have a border-bott
juliandoucette 2017/09/12 13:21:53 Acknowledged.
juliandoucette 2017/09/22 13:49:13 Can you add a comment about this?
ire 2017/09/25 07:25:26 Done.
40 { 43 {
41 border-top: 1px dotted $gray; 44 border-top: 1px dotted $gray;
42 } 45 }
43 46
44 .underlined-list .one-half:nth-child(2) a 47 .underlined-list .one-half:nth-child(2) a
45 { 48 {
46 @media (min-width: $tablet-breakpoint) 49 @media (min-width: $tablet-breakpoint)
47 { 50 {
48 border-top: 1px dotted $gray; 51 border-top: 1px dotted $gray;
49 } 52 }
50 } 53 }
54
55 // Horizontal List ///////////////////////////////////////////////////////////// ///
56
57 .horizontal-list
58 {
59 display: inline;
60 list-style: none;
61 }
62
63 .horizontal-list li
64 {
65 display: inline;
66 list-style: none;
67 }
68
69 [dir="rtl"] .horizontal-list
70 {
71 padding: 0;
72 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld