Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/scss/content/_typography.scss

Issue 29516622: Issue 5511 - Create Product Help Home Template for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Left Patch Set: Created Aug. 15, 2017, 3:01 p.m.
Right Patch Set: Addressed final NITs Created Sept. 25, 2017, 7:24 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/scss/components/_lists.scss ('k') | static/scss/layout/_body.scss » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 // This file is part of help.eyeo.com. 1 // This file is part of help.eyeo.com.
2 // Copyright (C) 2017 Eyeo GmbH 2 // Copyright (C) 2017 Eyeo GmbH
3 // 3 //
4 // help.eyeo.com is free software: you can redistribute it and/or modify 4 // help.eyeo.com is free software: you can redistribute it and/or modify
5 // it under the terms of the GNU General Public License as published by 5 // it under the terms of the GNU General Public License as published by
6 // the Free Software Foundation, either version 3 of the License, or 6 // the Free Software Foundation, either version 3 of the License, or
7 // (at your option) any later version. 7 // (at your option) any later version.
8 // 8 //
9 // help.eyeo.com is distributed in the hope that it will be useful, 9 // help.eyeo.com is distributed in the hope that it will be useful,
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of
11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 // GNU General Public License for more details. 12 // GNU General Public License for more details.
13 // 13 //
14 // You should have received a copy of the GNU General Public License 14 // You should have received a copy of the GNU General Public License
15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>. 15 // along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.
16 16
17 body
18 {
19 color: $font-color-default;
20 font-family: $primary-font;
21 font-size: $medium-font;
22 font-weight: $normal-weight;
23 line-height: 1.5;
24 }
25
26 .h1 17 .h1
juliandoucette 2017/08/24 11:14:00 Note: Maybe we should make these configurable via
ire 2017/08/28 14:54:48 I like the idea
27 { 18 {
28 font-size: $font-size-h3; 19 font-size: $font-size-h3;
29 line-height: 1.2; 20 line-height: 1.2;
30 21
31 @media (min-width: $mobile-breakpoint) 22 @media (min-width: $phablet-breakpoint)
32 { 23 {
33 font-size: $font-size-h2; 24 font-size: $font-size-h2;
34 } 25 }
35 26
36 @media (min-width: $tablet-breakpoint) 27 @media (min-width: $tablet-breakpoint)
37 { 28 {
38 font-size: $font-size-h1; 29 font-size: $font-size-h1;
39 } 30 }
40 } 31 }
41 32
42 .h4 33 .h4
43 { 34 {
44 font-size: $font-size-h4; 35 font-size: $font-size-h4;
45 font-weight: $bold-weight; 36 font-weight: $bold-weight;
46 text-transform: uppercase; 37 text-transform: uppercase;
47 } 38 }
48 39
49 .heading-icon 40 .heading-icon
50 { 41 {
51 height: 0.9em; 42 height: 0.9em;
juliandoucette 2017/08/24 11:14:00 NIT: My spidy-senses are telling me that 90% may b
ire 2017/08/28 14:54:48 90% makes the icon really small. I can't figure ou
juliandoucette 2017/09/12 13:21:53 Acknowledged. % height didn't work when I tested j
52 margin-right: 0.3em; 43 margin-right: 0.3em;
53 } 44 }
54 45
55 [dir="rtl"] .heading-icon 46 [dir="rtl"] .heading-icon
56 { 47 {
57 margin-right: 0; 48 margin-right: 0;
58 margin-left: 0.3em; 49 margin-left: 0.3em;
59 } 50 }
51
52 .product-heading
53 {
54 @extend .h1;
55 @extend .section;
56 @extend .ta-center;
57 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld