Issue 5511 - Create Product Help Home Template for help.eyeo.com

static/scss/layout/_body.scss

 // This file is part of help.eyeo.com.
 // Copyright (C) 2017 Eyeo GmbH
 //
 // help.eyeo.com is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // help.eyeo.com is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with help.eyeo.com.  If not, see <http://www.gnu.org/licenses/>.
 
 .outer
 {
-  margin-top: $site-header-height;
-  background-image: url("/img/png/help-bg.png");

[juliandoucette, 2017/08/24 11:14:01]

NIT: Apparently our code style guide suggests no quotes here (this is not my
personal preference)

[ire, 2017/08/28 14:54:49]

Oh okay. I thought it was the other way around, I even mentioned it in a review
of Manvel's code haha

[juliandoucette, 2017/09/12 13:21:53]

That's probably my fault :D (or, at least, you can blame me if you want.)

+  background-image: url(/img/png/help-bg.png);
   background-repeat: no-repeat;
 }
 
-.main

[juliandoucette, 2017/08/24 11:14:00]

NIT: Isn't there usually only one <main> or #main? In that case, perhaps we
should considering using an element or ID selector.

[ire, 2017/08/28 14:54:49]

Changed to #main

+#main
 {
   padding-top: $lg;
   padding-bottom: $xl;
 
-  @media (min-width: $mobile-breakpoint)
+  @media (min-width: $phablet-breakpoint)
   {
     padding-top: $xl;
   }
-}
-
-.wrapper

[juliandoucette, 2017/08/24 11:14:01]

NIT: If you agree with my comment about .nav-wrapper in the header than it may
make more sense to use a _base.css .container as a parent and then set the width
of #main or <main> instead.

[ire, 2017/08/28 14:54:48]

Okay, I think it makes sense to update this when the review for the header is
set

-{
-  width: $content-width;
-  max-width: $content-max-width;
-  margin-right: auto;
-  margin-left: auto;
 }
 
 .section
 {
   margin-bottom: $lg;
 
-  @media (min-width: $mobile-breakpoint)
+  @media (min-width: $phablet-breakpoint)
   {
     margin-bottom: $xl;
   }
 }