globals/get_page_name.py - Issue 29516622: Issue 5511 - Create Product Help Home Template for help.eyeo.com

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: globals/get_page_name.py

Issue 29516622: Issue 5511 - Create Product Help Home Template for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com

Left Patch Set: Rebase, Formatting template Created Sept. 19, 2017, 10:25 a.m.

Right Patch Set: Addressed final NITs Created Sept. 25, 2017, 7:24 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 # This file is part of help.eyeo.com.	1 # This file is part of help.eyeo.com.

2 # Copyright [C] 2016 Eyeo GmbH	2 # Copyright [C] 2016 Eyeo GmbH

3 #	3 #

4 # help.eyeo.com is free software: you can redistribute it and/or modify	4 # help.eyeo.com is free software: you can redistribute it and/or modify

5 # it under the terms of the GNU General Public License as published by	5 # it under the terms of the GNU General Public License as published by

6 # the Free Software Foundation, either version 3 of the License, or	6 # the Free Software Foundation, either version 3 of the License, or

7 # [at your option] any later version.	7 # [at your option] any later version.

8 #	8 #

9 # help.eyeo.com is distributed in the hope that it will be useful,	9 # help.eyeo.com is distributed in the hope that it will be useful,

10 # but WITHOUT ANY WARRANTY; without even the implied warranty of	10 # but WITHOUT ANY WARRANTY; without even the implied warranty of

11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the	11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

12 # GNU General Public License for more details.	12 # GNU General Public License for more details.

13 #	13 #

14 # You should have received a copy of the GNU General Public License	14 # You should have received a copy of the GNU General Public License

15 # along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.	15 # along with help.eyeo.com. If not, see <http://www.gnu.org/licenses/>.

16	16

17 def get_page_name(url):	17 def get_page_name(url):
juliandoucette 2017/09/22 13:49:13 NIT: I don't think we newline under definition dec NIT: I don't think we newline under definition declarations ire 2017/09/25 07:25:27 Done. Show quoted text On 2017/09/22 13:49:13, juliandoucette wrote: > NIT: I don't think we newline under definition declarations Done.
18

19 split_url = url.split('/')	18 split_url = url.split('/')

20 return split_url[ len(split_url) - 1 ]	19 return split_url[len(split_url) - 1]
juliandoucette 2017/09/22 13:49:13 NIT: I don't think we space inside brackets NIT: I don't think we space inside brackets ire 2017/09/25 07:25:26 Done. Show quoted text On 2017/09/22 13:49:13, juliandoucette wrote: > NIT: I don't think we space inside brackets Done.
LEFT	RIGHT