Issue 5347 - Do not show composer menu item on Firefox for Android

lib/filterComposer.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
- * Copyright (C) 2006-2017 eyeo GmbH
+ * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /** @module filterComposer */
 
 "use strict";
 
 const {defaultMatcher} = require("matcher");
 const {RegExpFilter} = require("filterClasses");
 const {FilterNotifier} = require("filterNotifier");
 const {Prefs} = require("prefs");
 const {extractHostFromFrame, stringifyURL, isThirdParty} = require("url");
 const {getKey, checkWhitelisted} = require("whitelisting");
 const {port} = require("messaging");
+const info = require("info");
 
 let readyPages = new ext.PageMap();
 
 /**
  * Checks whether the given page is ready to use the filter composer
  *
  * @param {Page} page
  * @return {boolean}
  */
 exports.isPageReady = page =>
@@ skipping 72 matching lines @@
         getKey(page, frame), specificOnly
       );
 
       if (!filter)
       {
         let filterText = url.replace(/^[\w-]+:\/+(?:www\.)?/, "||");
 
         if (specificOnly)
           filterText += "$domain=" + docDomain;
 
-        if (filters.indexOf(filterText) == -1)
+        if (!filters.includes(filterText))
           filters.push(filterText);
       }
     }
 
     // If we couldn't generate any blocking filters, fallback to element hiding
     if (filters.length == 0 && !checkWhitelisted(page, frame,
                                                  RegExpFilter.typeMap.ELEMHIDE))
     {
       // Generate CSS selectors based on the element's "id" and
       // "class" attribute.
@@ skipping 41 matching lines @@
     page.sendMessage({type: "composer.content.contextMenuClicked"});
   }
 };
 
 function updateContextMenu(page, filter)
 {
   page.contextMenus.remove(contextMenuItem);
 
   if (typeof filter == "undefined")
     filter = checkWhitelisted(page);
-  if (!filter && Prefs.shouldShowBlockElementMenu && readyPages.has(page) &&
-      // Firefox for Android does not support the windows API, which is
-      // required for the composer to work.

[Wladimir Palant, 2017/08/17 12:22:49]

Not really, we could fall back to creating a new tab - something that makes more
sense on Android anyway.

[Manish Jethani, 2017/08/17 13:25:19]

Do you think it makes sense to make the composer work using tabs? 

Maybe the answer is different for phone and tablet.

Anyway, the composer opens a dialog, I'm not sure it would be a good user
experience to use a tab instead on mobile.

[Sebastian Noack, 2017/08/18 09:23:01]

Also, the user experience when selecting elements isn't great without a mouse,
since elements to be blocked are highlighted on hover so that you know what
would be blocked before you click. This obviously doesn't work on touch devices.
IMO, there is no point to make the composer work there.

[Wladimir Palant, 2017/08/18 20:52:32]

Ok, fine with me.

[Sebastian Noack, 2017/08/23 12:00:35]

Perhaps we should rather check for `info.application != "fennec"` here, since we
seem to agree that the composer doesn't make much sense on mobile, regardless of
the lack of support of the windows API.

[Manish Jethani, 2017/08/24 10:34:59]

Done.

-      "windows" in chrome)
+
+  // We don't support the filter composer on Firefox for Android, because the
+  // user experience on mobile is quite different.
+  if (info.application != "fennec" &&
+      !filter && Prefs.shouldShowBlockElementMenu && readyPages.has(page))
   {
     page.contextMenus.create(contextMenuItem);
   }
 }
 
 FilterNotifier.on("page.WhitelistingStateRevalidate", updateContextMenu);
 
 Prefs.on("shouldShowBlockElementMenu", () =>
 {
   ext.pages.query({}, pages =>
@@ skipping 59 matching lines @@
 
 port.on("composer.quoteCSS", (message, sender) =>
 {
   return quoteCSS(message.CSS);
 });
 
 ext.pages.onLoading.addListener(page =>
 {
   page.sendMessage({type: "composer.content.finished"});
 });