tests/frontmatter_samples/front_matter_json.html - Issue 29516687: Issue 4488 - Add support for JSON page front matter

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: tests/frontmatter_samples/front_matter_json.html

Issue 29516687: Issue 4488 - Add support for JSON page front matter (Closed) Base URL: https://hg.adblockplus.org/cms

Patch Set: Created Aug. 16, 2017, 12:43 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

OLD	NEW
(Empty)
	1 <!-- {

	2 "title": "Awesome page",
	Vasily Kuznetsov 2017/08/16 18:34:56 Here we should probably have a bit more diversity Here we should probably have a bit more diversity of variables. Perhaps one string, one number, a dictionary and a list would be good. However, many variables of the same type are probably excessive. rosie 2017/08/19 01:56:34 Integrated this test with test_site and expected_o Show quoted text On 2017/08/16 18:34:56, Vasily Kuznetsov wrote: > Here we should probably have a bit more diversity of variables. Perhaps one > string, one number, a dictionary and a list would be good. However, many > variables of the same type are probably excessive. Integrated this test with test_site and expected_output. Also updated the variables as suggested. rosie 2017/08/19 01:56:34 Done. Show quoted text On 2017/08/16 18:34:56, Vasily Kuznetsov wrote: > Here we should probably have a bit more diversity of variables. Perhaps one > string, one number, a dictionary and a list would be good. However, many > variables of the same type are probably excessive. Done.
	3 "description": "Awesome description",

	4 "image": {

	5 "url": "/img/awesome.jpg",

	6 "type": "image/jpg",

	7 "width": "1024",

	8 "height": "768",

	9 "alt": "Awesome image"

	10 }

	11 } -->

	12 <h1>Awesome page</h1>

OLD	NEW