tests/test_parse_page_content.py - Issue 29516687: Issue 4488 - Add support for JSON page front matter

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: tests/test_parse_page_content.py

Issue 29516687: Issue 4488 - Add support for JSON page front matter (Closed) Base URL: https://hg.adblockplus.org/cms

Patch Set: Created Aug. 16, 2017, 12:43 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #!/usr/bin/env python2
	Vasily Kuznetsov 2017/08/16 18:34:56 I think we've discussed this and I have suggested I think we've discussed this and I have suggested to have a separate file for the metadata parsing tests rather than putting the tests into another file. However, at that point I didn't realize the possibility of using the same approach as for most other CMS features: we can make the page use the variables in the content somehow and then check the rendered pages against "correct" expected outputs. I think this approach would be preferable in this case because we would not add any new testing code, only testing data. rosie 2017/08/19 01:56:34 Done. Show quoted text On 2017/08/16 18:34:56, Vasily Kuznetsov wrote: > I think we've discussed this and I have suggested to have a separate file for > the metadata parsing tests rather than putting the tests into another file. > However, at that point I didn't realize the possibility of using the same > approach as for most other CMS features: we can make the page use the variables > in the content somehow and then check the rendered pages against "correct" > expected outputs. I think this approach would be preferable in this case because > we would not add any new testing code, only testing data. Done.
	2

	3 import os

	4

	5 from cms.converters import parse_page_content

	6

	7 test_path = os.path.join(os.path.dirname(os.path.abspath(__file__)),

	8 'frontmatter_samples')

	9

	10

	11 def test_parse_page_content():

	12 page = 'test_page_name'

	13 with open(os.path.join(test_path, 'front_matter_orig.html')) as orig_data:

	14 orig_content = orig_data.read()

	15 orig = parse_page_content(page, orig_content)

	16 with open(os.path.join(test_path, 'front_matter_json.html')) as json_data:

	17 json_content = json_data.read()

	18 json = parse_page_content(page, json_content)

	19 assert orig[0] == json[0]

OLD	NEW

« tests/frontmatter_samples/front_matter_orig.html ('K') | « tests/frontmatter_samples/front_matter_orig.html ('k') | no next file » | no next file with comments »