lib/content/elemHideEmulation.js - Issue 29517687: Issue 5079, 5516 - Use webpack for browser tests, modules for content scripts

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: lib/content/elemHideEmulation.js

Issue 29517687: Issue 5079, 5516 - Use webpack for browser tests, modules for content scripts (Closed)

Left Patch Set: Created Aug. 16, 2017, 3:40 p.m.

Right Patch Set: Addressed nits Created Aug. 17, 2017, 1:25 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 /*	1 /*

2 * This file is part of Adblock Plus <https://adblockplus.org/>,	2 * This file is part of Adblock Plus <https://adblockplus.org/>,

3 * Copyright (C) 2006-2017 eyeo GmbH	3 * Copyright (C) 2006-2017 eyeo GmbH

4 *	4 *

5 * Adblock Plus is free software: you can redistribute it and/or modify	5 * Adblock Plus is free software: you can redistribute it and/or modify

6 * it under the terms of the GNU General Public License version 3 as	6 * it under the terms of the GNU General Public License version 3 as

7 * published by the Free Software Foundation.	7 * published by the Free Software Foundation.

8 *	8 *

9 * Adblock Plus is distributed in the hope that it will be useful,	9 * Adblock Plus is distributed in the hope that it will be useful,

10 * but WITHOUT ANY WARRANTY; without even the implied warranty of	10 * but WITHOUT ANY WARRANTY; without even the implied warranty of

(...skipping 458 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
469 {	469 {

470 let {document} = this.window;	470 let {document} = this.window;

471 this.addSelectors();	471 this.addSelectors();

472 document.addEventListener("load", this.onLoad.bind(this), true);	472 document.addEventListener("load", this.onLoad.bind(this), true);

473 }	473 }

474 });	474 });

475 }	475 }

476 };	476 };

477	477

478 exports.ElemHideEmulation = ElemHideEmulation;	478 exports.ElemHideEmulation = ElemHideEmulation;

479 exports.splitSelector = splitSelector;
hub 2017/08/16 16:14:46 do we still need this since it is exported from co do we still need this since it is exported from common.js ? kzar 2017/08/17 12:40:21 Done. Show quoted text On 2017/08/16 16:14:46, hub wrote: > do we still need this since it is exported from common.js ? Done.
LEFT	RIGHT