Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: includes/contact.html

Issue 29519587: Issue 5534 - Create Contact Section for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Created Aug. 18, 2017, 12:30 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | static/img/png/accent-bg.png » ('j') | static/scss/base/_utilities.scss » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 <section class="section-accent">
2 <div class="wrapper-sm">
3
4 <h2 class="h2 ta-center underlined">
5 {{contact[heading] Still looking for help?}}
juliandoucette 2017/08/30 11:33:06 NIT/Suggest: ID contact-heading (I know... DRY but
ire 2017/09/25 08:47:35 Done.
6 </h2>
7
8 <div class="row">
9 <section class="column one-half section">
juliandoucette 2017/08/30 11:33:06 Note: I think we should be consistent about whethe
ire 2017/09/25 08:47:35 I think it depends on where we want the spacing. I
10 <header class="underlined">
11 <h3 class="h4">
12 {{contact-social[heading] Get in touch}}
13 </h3>
14 <p>
15 {{contact-social-description[paragraph] Drop us a line on Twitter or Facebook and get your question answered ASAP.}}
16 </p>
17 </header>
18 <a href="https://www.facebook.com/adblockplus">
19 <img class="heading-icon" src="/img/png/logo-facebook.png" srcset="/im g/svg/logo-facebook.svg 2x" alt="">
ire 2017/08/18 12:34:30 I left a null alt attribute here since the text wi
juliandoucette 2017/08/30 11:33:06 NIT/Suggest: Describe the logo. It's a "rounded sq
ire 2017/09/25 08:47:35 Done. I haven't heard any evidence on the contrary
20 Facebook
ire 2017/08/18 12:34:30 Do we translate this?
juliandoucette 2017/08/30 11:33:06 Good question. I don't think it matters. The only
ire 2017/09/25 08:47:35 I agree with you that translating everything makes
21 </a>
22 <a href="https://twitter.com/AdblockPlus">
23 <img class="heading-icon" src="/img/png/logo-twitter.png" srcset="/img /svg/logo-twitter.svg 2x" alt="">
24 Twitter
25 </a>
26 <a href="mailto:support@adblockplus.org">
27 <img class="heading-icon" src="/img/png/email-icon.png" srcset="/img/s vg/email-icon.svg 2x" alt="">
28 Email
29 </a>
30 </section>
31
32 <section class="column one-half section">
33 <header class="underlined">
34 <h3 class="h4">
35 {{contact-developer[heading] Looking for developer support?}}
36 </h3>
37 <p>
38 {{contact-developer-description[paragraph] Find source code, release notes, advanced documentation and more.}}
39 </p>
40 </header>
41 <a href="https://adblockplus.org/forum">
42 {{contact-developer-support-link[link] Developer Support}}
43 </a>
44 </section>
45 </div>
46
47 </div>
48 </section>
OLDNEW
« no previous file with comments | « no previous file | static/img/png/accent-bg.png » ('j') | static/scss/base/_utilities.scss » ('J')

Powered by Google App Engine
This is Rietveld