Issue 5534 - Create Contact Section for help.eyeo.com

static/scss/layout/_body.scss

 // This file is part of help.eyeo.com.
 // Copyright (C) 2017 Eyeo GmbH
 //
 // help.eyeo.com is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // help.eyeo.com is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with help.eyeo.com.  If not, see <http://www.gnu.org/licenses/>.
 
 .outer
 {
-  margin-top: $site-header-height;
-  background-image: url("/img/png/help-bg.png");
+  background-image: url(/img/png/help-bg.png);
   background-repeat: no-repeat;
 }
 
-.main
+#main
 {
   padding-top: $lg;
   padding-bottom: $xl;
 
-  @media (min-width: $mobile-breakpoint)
+  @media (min-width: $phablet-breakpoint)
   {
     padding-top: $xl;
   }
 }
 
-.wrapper

[juliandoucette, 2017/08/30 11:33:06]

NIT: Wouldn't it would be simpler to just add margins to these wrappers and rely
on the default grid behaviour. e.g.

.container
  .less_wide_section (margin 100px)
    .row
       .col (etc)
   .even_less_wide_section (margin 200px)
     .row
      .col (etc)

where .less_wide_section and .even_less_wide_section only have (or have
different) margin inside min-width desktop or tablet.

(names are for demonstration purposes only)

---

Afterthought: I see the beauty in the solution that you implemented. I will
think about this a little longer and await your feedback. The above
NIT/Suggestion is not a strong opinion.

[ire, 2017/09/25 08:47:35]

I modified this slightly to make use of the `container` class.

-{
-  width: $content-width;
-  max-width: $content-max-width;
-  margin-right: auto;
-  margin-left: auto;
-}
-
-.wrapper-sm
+.tablet-width
 {
   width: $tablet-width;
-  max-width: $content-max-width;
-  margin-right: auto;
-  margin-left: auto;
 }
 
 .section
 {
   margin-bottom: $lg;
 
-  @media (min-width: $mobile-breakpoint)
+  @media (min-width: $phablet-breakpoint)
   {
     margin-bottom: $xl;
   }
 }
 
 .section-accent

[ire, 2017/08/18 12:34:30]

These styles are pretty much exclusive to the contact section. I'm considering
changing this to a #contact selector instead. Any thoughts?

[juliandoucette, 2017/08/30 11:33:06]

No strong opinion. I think it makes sense to have an .accent-bg class in
website-defaults that can modify .section. And I wouldn't mind extending that by
class or ID in a specific website.

[ire, 2017/09/25 08:47:35]

I'll leave it the way it is for now then.

 {
   padding-top: $xl;
   padding-bottom: $xl;
   background-image: url("/img/png/accent-bg.png");
+  background-size: 100%;
   background-repeat: no-repeat;
   background-position: center 0;
 }
-
-.section-accent a

[juliandoucette, 2017/08/30 11:33:06]

NIT: I think that these links are link buttons at the bottom of cards and this
selector is too general. We could have text links inside the text content of
these cards.

[ire, 2017/09/25 08:47:35]

I changed this to a horizontal list, and styled the list items instead

-{
-  display: inline-block;
-  margin-right: $md;
-  font-weight: $bold-weight;
-  text-transform: uppercase;
-}
-
-[dir="rtl"]
-{
-  .section-accent a
-  {
-    margin-right: 0;
-    margin-left: $md;
-  }
-}