templates/default.tmpl - Issue 29519587: Issue 5534 - Create Contact Section for help.eyeo.com

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: templates/default.tmpl

Issue 29519587: Issue 5534 - Create Contact Section for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com

Left Patch Set: Update alt text, rebase, refactor links in section-accent Created Sept. 25, 2017, 8:45 a.m.

Right Patch Set: Addressed final NITs Created Oct. 10, 2017, 6:33 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {% extends "templates/minimal" %}	1 {% extends "templates/minimal" %}

2	2

3 {% block body %}	3 {% block body %}

4 {{ body \| safe }}	4 {{ body \| safe }}

	5 {% endblock %}

5	6

	7 {% block footer %}

6 <? include contact ?>	8 <? include contact ?>
ire 2017/09/25 08:47:36 I'm having an issue here. The contact section does I'm having an issue here. The contact section doesn't show up on the product help home page (i.e. pages that use a template that extends this template). Is there an issue with the cms not including things from extended templates? juliandoucette 2017/09/25 12:15:22 The contents of blocks are replaced; not extended. Show quoted text On 2017/09/25 08:47:36, ire wrote: > I'm having an issue here. The contact section doesn't show up on the product > help home page (i.e. pages that use a template that extends this template). Is > there an issue with the cms not including things from extended templates? The contents of blocks are replaced; not extended. e.g. # parent.tmpl {% block test %} Parent text {% blockend %} # child.tmpl {% extends "templates/parent" %} {% block test %} Child text {% endblock %} # results Child text NOT Parent text Child text If you want Parent text AND Child text to appear then Parent text must be outside the block that is overwritten (or in a separate block). Does that make sense? (You are overwriting the contents of the "body" block in the "product-home" template.) ire 2017/09/25 14:02:25 Ah I see. Got it. Putting the include outside th Show quoted text On 2017/09/25 12:15:22, juliandoucette wrote: > On 2017/09/25 08:47:36, ire wrote: > > I'm having an issue here. The contact section doesn't show up on the product > > help home page (i.e. pages that use a template that extends this template). Is > > there an issue with the cms not including things from extended templates? > > The contents of blocks are replaced; not extended. e.g. > > # parent.tmpl > > {% block test %} > Parent text > {% blockend %} > > # child.tmpl > > {% extends "templates/parent" %} > > {% block test %} > Child text > {% endblock %} > > # results > > Child text > > NOT > > Parent text > Child text > > If you want Parent text AND Child text to appear then Parent text must be > outside the block that is overwritten (or in a separate block). > > Does that make sense? > > (You are overwriting the contents of the "body" block in the "product-home" > template.) Ah I see. Got it. Putting the include outside the "body" block made it not render at all, so I created a separate block for it.
7 {% endblock %}	9 {% endblock %}

LEFT	RIGHT