Delta Between Two Patch Sets: includes/contact.html
Issue 29519587:
Issue 5534 - Create Contact Section for help.eyeo.com (Closed)
Base URL: https://hg.adblockplus.org/help.eyeo.com
Left Patch Set: #contact element, refactoring
Created Sept. 28, 2017, 9:42 a.m.
Right Patch Set: Addressed final NITs
Created Oct. 10, 2017, 6:33 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« no previous file
|
static/img/png/accent-bg.png » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <aside id="contact" class="section-accent"> | 1 <aside id="contact" class="section-accent"> |
| 2 <div class="container tablet-width"> | 2 <div class="container tablet-width"> |
| 3 | 3 |
| 4 <h2 class="h2 ta-center underlined"> | 4 <h2 class="h2 ta-center underlined"> |
| 5 {{contact-heading[heading] Still looking for help?}} | 5 {{contact-heading[heading] Still looking for help?}} |
| 6 </h2> | 6 </h2> |
| 7 | 7 |
| 8 <div class="row"> | 8 <div class="row"> |
| 9 <section class="column one-half section"> | 9 <section class="column one-half section"> |
| 10 <header class="underlined"> | 10 <header class="underlined"> |
| 11 <h3 class="h4"> | 11 <h3 class="h4"> |
| 12 {{contact-social[heading] Get in touch}} | 12 {{contact-social[heading] Get in touch}} |
| 13 </h3> | 13 </h3> |
| 14 <p> | 14 <p> |
| 15 {{contact-social-description[paragraph] Drop us a line on Twitter or Facebook and get your question answered ASAP.}} | 15 {{contact-social-description[paragraph] Drop us a line on Twitter or Facebook and get your question answered ASAP.}} |
| 16 </p> | 16 </p> |
| 17 </header> | 17 </header> |
| 18 <ul class="horizontal-list"> | 18 <ul class="horizontal-list"> |
| 19 <li> | 19 <li> |
| 20 <a href="https://www.facebook.com/adblockplus"> | 20 <a href="https://www.facebook.com/adblockplus"> |
| 21 <img class="heading-icon" src="/img/png/logo-facebook.png" srcset= "/img/svg/logo-facebook.svg 2x" | 21 <img class="heading-icon" src="/img/png/logo-facebook.png" srcset= "/img/svg/logo-facebook.svg 2x" |
| 22 alt="{{facebook-logo[Image alt text] Rounded blue square Face book hieroglyph}}"> | 22 alt="{{facebook-logo[Image alt text] Rounded blue square Face book glyph}}"> |
| 23 {{facebook[Brand name] Facebook}} | 23 {{facebook[Brand name] Facebook}} |
|
juliandoucette
2017/10/09 22:00:39
SuperNIT: There is extra whitespace before/after t
| |
| 24 </a> | 24 </a> |
| 25 </li> | 25 </li> |
| 26 <li> | 26 <li> |
| 27 <a href="https://twitter.com/AdblockPlus"> | 27 <a href="https://twitter.com/AdblockPlus"> |
| 28 <img class="heading-icon" src="/img/png/logo-twitter.png" srcset=" /img/svg/logo-twitter.svg 2x" | 28 <img class="heading-icon" src="/img/png/logo-twitter.png" srcset=" /img/svg/logo-twitter.svg 2x" |
| 29 alt="{{ftwitter-logo[Image alt text] Blue Twitter hieroglyph} }"> | 29 alt="{{ftwitter-logo[Image alt text] Blue Twitter glyph}}"> |
|
juliandoucette
2017/10/09 22:00:39
NIT/Suggest: *just* "glyph"
Source: http://wikidi
ire
2017/10/10 18:36:30
Done.
| |
| 30 {{twitter[Brand name] Twitter}} | 30 {{twitter[Brand name] Twitter}} |
| 31 </a> | 31 </a> |
| 32 </li> | 32 </li> |
| 33 <li> | 33 <li> |
| 34 <a href="mailto:support@adblockplus.org"> | 34 <a href="mailto:support@adblockplus.org"> |
| 35 <img class="heading-icon" src="/img/png/email-icon.png" srcset="/i mg/svg/email-icon.svg 2x" | 35 <img class="heading-icon" src="/img/png/email-icon.png" srcset="/i mg/svg/email-icon.svg 2x" |
| 36 alt="{{email-icon[Image alt text] Blue envelope}}"> | 36 alt="{{email-icon[Image alt text] Blue envelope}}"> |
| 37 {{email[Link text] Email}} | 37 {{email[Link text] Email}} |
| 38 </a> | 38 </a> |
| 39 </li> | 39 </li> |
| 40 </ul> | 40 </ul> |
| 41 | |
| 42 | |
| 43 | |
| 44 </section> | 41 </section> |
| 45 | |
| 46 <section class="column one-half section"> | 42 <section class="column one-half section"> |
| 47 <header class="underlined"> | 43 <header class="underlined"> |
| 48 <h3 class="h4"> | 44 <h3 class="h4"> |
| 49 {{contact-developer[heading] Looking for developer support?}} | 45 {{contact-developer[heading] Looking for developer support?}} |
| 50 </h3> | 46 </h3> |
| 51 <p> | 47 <p> |
| 52 {{contact-developer-description[paragraph] Find source code, release notes, advanced documentation and more.}} | 48 {{contact-developer-description[paragraph] Find source code, release notes, advanced documentation and more.}} |
| 53 </p> | 49 </p> |
| 54 </header> | 50 </header> |
| 55 <ul class="horizontal-list"> | 51 <ul class="horizontal-list"> |
| 56 <li> | 52 <li> |
| 57 <a href="https://adblockplus.org/forum"> | 53 <a href="https://adblockplus.org/forum"> |
| 58 {{contact-developer-support-link[link] Developer Support}} | 54 {{contact-developer-support-link[link] Developer Support}} |
| 59 </a> | 55 </a> |
| 60 </li> | 56 </li> |
| 61 </ul> | 57 </ul> |
| 62 </section> | 58 </section> |
| 63 </div> | 59 </div> |
| 64 | 60 |
| 65 </div> | 61 </div><!-- .container --> |
| 66 </aside> | 62 </aside> |
| LEFT | RIGHT |
« no previous file
|
static/img/png/accent-bg.png » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
