Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: new-options.html

Issue 29519636: Issue 5538 - Implement "Help" tab for new options page (Closed)
Patch Set: Created Aug. 23, 2017, 5:28 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <!-- 2 <!--
3 - This file is part of Adblock Plus <https://adblockplus.org/>, 3 - This file is part of Adblock Plus <https://adblockplus.org/>,
4 - Copyright (C) 2006-present eyeo GmbH 4 - Copyright (C) 2006-present eyeo GmbH
5 - 5 -
6 - Adblock Plus is free software: you can redistribute it and/or modify 6 - Adblock Plus is free software: you can redistribute it and/or modify
7 - it under the terms of the GNU General Public License version 3 as 7 - it under the terms of the GNU General Public License version 3 as
8 - published by the Free Software Foundation. 8 - published by the Free Software Foundation.
9 - 9 -
10 - Adblock Plus is distributed in the hope that it will be useful, 10 - Adblock Plus is distributed in the hope that it will be useful,
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
288 <button class="i18n_options_customFilter_save" data-action="save -custom-filters"> 288 <button class="i18n_options_customFilter_save" data-action="save -custom-filters">
289 </button> 289 </button>
290 <button class="i18n_options_customFilter_cancel" data-action="ca ncel-custom-filters"> 290 <button class="i18n_options_customFilter_cancel" data-action="ca ncel-custom-filters">
291 </button> 291 </button>
292 </div> 292 </div>
293 </div> 293 </div>
294 </section> 294 </section>
295 </div> 295 </div>
296 296
297 <!-- Help tab content --> 297 <!-- Help tab content -->
298 <div id="content-help" role="tabpanel" aria-labelledby="tab-help"> 298 <div id="content-help" role="tabpanel" aria-labelledby="tab-help">
ire 2017/08/24 09:17:47 There is no aria-hidden attribute attribute on the
saroyanm 2017/08/24 13:22:27 I agree, I think we should improve that separately
ire 2017/08/25 08:52:49 Acknowledged.
299 <h1 class="i18n_options_faq_title"></h1> 299 <h1 class="i18n_options_tab_help"></h1>
300 <p class="i18n_options_faq_description"></p> 300 <p class="i18n_options_help_description"></p>
301 <p> 301 <section>
302 <a id="link-faq" class="i18n_options_faq_title" target="_blank"></a > 302 <h2 class="i18n_options_support_title"></h2>
303 </p> 303 <ul>
304 <h1 class="i18n_options_forum_title"></h1> 304 <li id="report-issue" class="i18n_options_report_issue"></li>
305 <p class="i18n_options_forum_description"></p> 305 <li id="report-ad" class="i18n_options_report_ad"></li>
306 <p> 306 <li id="report-bug" class="i18n_options_report_bug"></li>
307 <a id="link-forum" class="i18n_options_forum_link" target="_blank"> </a> 307 <li id="report-forum" class="i18n_options_report_forum"></li>
308 </p> 308 </ul>
309 <h1 class="i18n_options_media_title"></h1> 309 </section>
310 <p class="i18n_options_media_description"></p> 310 <section>
311 <p> 311 <h2 class="i18n_options_social_title"></h2>
312 <span id="share-general"> 312 <p class="i18n_options_social_description"></p>
313 <a id="link-twitter" target="_blank">Twitter</a> 313 <div id="social">
314 <a id="link-facebook" target="_blank">Facebook</a> 314 <ul id="social-general">
315 <a id="link-gplus" target="_blank">Google+</a> 315 <li><a id="twitter">Twitter</a></li>
316 </span> 316 <li><a id="facebook">Facebook</a></li>
317 <span id="share-chinese"> 317 <li><a id="google-plus">Google Plus</a></li>
318 <a id="link-renren" target="_blank">renren</a> 318 </ul>
319 <a id="link-weibo" target="_blank">weibo</a> 319 <ul id="social-chinese">
ire 2017/08/24 09:17:47 NIT: I think the class name "social-zh" may be mor
saroyanm 2017/08/24 13:22:28 I think we shouldn't put implementation details in
ire 2017/08/25 08:52:49 Acknowledged.
320 </span> 320 <li><a id="weibo">Weibo</a></li>
saroyanm 2017/08/23 17:36:10 Weibo icon is yet missing -> https://bitbucket.org
ire 2017/08/24 09:17:47 Acknowledged.
321 </p> 321 </ul>
322 <p>
ire 2017/08/24 09:17:47 This should be wrapped in a <strong> element, the
saroyanm 2017/08/24 13:22:28 agree
saroyanm 2017/08/24 18:19:42 Done.
323 <span class="i18n_options_email"></span>
324 <a href="mailto:support@adblockplus.org">support@adblockplus.org </a>
325 </p>
326 </div>
327 </section>
322 </div> 328 </div>
323 </div> 329 </div>
324 </div> 330 </div>
325 331
326 <!-- Dialog --> 332 <!-- Dialog -->
327 <div id="dialog" role="dialog" aria-hidden="true"> 333 <div id="dialog" role="dialog" aria-hidden="true">
328 <header> 334 <header>
329 <span id="dialog-title"> 335 <span id="dialog-title">
330 <span id="dialog-title-custom" class="i18n_options_dialog_custom_title "></span> 336 <span id="dialog-title-custom" class="i18n_options_dialog_custom_title "></span>
331 <span id="dialog-title-language-add" class="i18n_options_dialog_langua ge_title"></span> 337 <span id="dialog-title-language-add" class="i18n_options_dialog_langua ge_title"></span>
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 <div class="url"></div> 375 <div class="url"></div>
370 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> 376 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button>
371 </div> 377 </div>
372 </div> 378 </div>
373 </div> 379 </div>
374 <!-- Placeholder element to determine when to wrap focus around --> 380 <!-- Placeholder element to determine when to wrap focus around -->
375 <span class="focus-last" tabindex="0"></span> 381 <span class="focus-last" tabindex="0"></span>
376 </div> 382 </div>
377 </body> 383 </body>
378 </html> 384 </html>
OLDNEW

Powered by Google App Engine
This is Rietveld