Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: locale/en-US/new-options.json

Issue 29519636: Issue 5538 - Implement "Help" tab for new options page (Closed)
Left Patch Set: Created Aug. 23, 2017, 5:28 p.m.
Right Patch Set: Created Aug. 25, 2017, 10:54 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | new-options.html » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 { 1 {
2 "options_page_title": { 2 "options_page_title": {
3 "description": "Options page title", 3 "description": "Options page title",
4 "message": "Adblock Plus Options" 4 "message": "Adblock Plus Options"
5 }, 5 },
6 "options_page_header_1": { 6 "options_page_header_1": {
7 "description": "Page title in navigation sidebar", 7 "description": "Page title in navigation sidebar",
8 "message": "Options" 8 "message": "Options"
9 }, 9 },
10 "options_page_header_2": { 10 "options_page_header_2": {
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 "message": "You aren't whitelisting any websites yet." 158 "message": "You aren't whitelisting any websites yet."
159 }, 159 },
160 "options_whitelist_empty_2": { 160 "options_whitelist_empty_2": {
161 "description": "Empty Whitelist placeholder", 161 "description": "Empty Whitelist placeholder",
162 "message": "Websites you trust and want to allow ads on will be shown here." 162 "message": "Websites you trust and want to allow ads on will be shown here."
163 }, 163 },
164 "options_whitelist_duplicate": { 164 "options_whitelist_duplicate": {
165 "description": "Duplicate hostname warning of whitelist text input", 165 "description": "Duplicate hostname warning of whitelist text input",
166 "message": "Website is already whitelisted" 166 "message": "Website is already whitelisted"
167 }, 167 },
168 "options_whitelist_description": { 168 "options_whitelist_description": {
ire 2017/08/24 09:17:47 Unrelated, but I noticed that this id "options_whi
saroyanm 2017/08/24 13:22:27 Well spotted, I'll fix that in the review with not
ire 2017/08/25 08:52:49 Acknowledged.
169 "description": "Section description in whitelisted tab", 169 "description": "Section description in whitelisted tab",
170 "message": "You've turned off ad blocking on these websites. You will see ad s on these websites." 170 "message": "You've turned off ad blocking on these websites. You will see ad s on these websites."
171 }, 171 },
172 "options_button_add": { 172 "options_button_add": {
173 "description": "Add button label", 173 "description": "Add button label",
174 "message": "add" 174 "message": "add"
175 }, 175 },
176 "options_advanced_description": { 176 "options_advanced_description": {
177 "description": "Advanced tab description", 177 "description": "Advanced tab description",
178 "message": "Customize Adblock Plus, add or remove filter lists, create and m aintain your own filter lists" 178 "message": "Customize Adblock Plus, add or remove filter lists, create and m aintain your own filter lists"
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
353 }, 353 },
354 "options_report_bug": { 354 "options_report_bug": {
355 "description": "'Support' section list item in Help tab", 355 "description": "'Support' section list item in Help tab",
356 "message": "Found a bug? <a>Send us a bug report</a>" 356 "message": "Found a bug? <a>Send us a bug report</a>"
357 }, 357 },
358 "options_report_forum": { 358 "options_report_forum": {
359 "description": "'Support' section list item in Help tab", 359 "description": "'Support' section list item in Help tab",
360 "message": "Want support from our community? <a>Go to the Forum</a>" 360 "message": "Want support from our community? <a>Go to the Forum</a>"
361 }, 361 },
362 "options_social_title": { 362 "options_social_title": {
363 "description": "'Section' title in Help tab", 363 "description": "'Section' title in Help tab",
ire 2017/08/24 09:17:47 Should this description be "'Social' title in Help
saroyanm 2017/08/24 13:22:27 Not necessarily, I think the information should be
ire 2017/08/25 08:52:49 Acknowledged. My comment was because the "Section"
364 "message": "Get in touch" 364 "message": "Get in touch"
365 }, 365 },
366 "options_social_description": { 366 "options_social_description": {
367 "description": "'Get in touch' section description in Help tab", 367 "description": "'Get in touch' section description in Help tab",
368 "message": "Have a question or a new idea? We're here to help." 368 "message": "Have a question or a new idea? We're here to help."
369 }, 369 },
370 "options_email": { 370 "options_email": {
371 "description": "Text in Help tab", 371 "description": "Email label in Help tab",
ire 2017/08/24 09:17:46 "Text in Help tab" may be too vague here
saroyanm 2017/08/24 13:22:27 Yes it is I couldn't come up with good description
saroyanm 2017/08/24 18:19:42 Done.
372 "message": "Email:" 372 "message": "Email:"
373 }, 373 },
374 "options_dialog_predefined_confirm": { 374 "options_dialog_predefined_confirm": {
375 "description": "Confirming to add a predefined subscription when asked in a dialog", 375 "description": "Confirming to add a predefined subscription when asked in a dialog",
376 "message": "Yes, use this filter list" 376 "message": "Yes, use this filter list"
377 }, 377 },
378 "options_dialog_predefined_title": { 378 "options_dialog_predefined_title": {
379 "description": "Dialog title for adding a predefined subscription", 379 "description": "Dialog title for adding a predefined subscription",
380 "message": "Do you really want to use this filter list?" 380 "message": "Do you really want to use this filter list?"
381 }, 381 },
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
477 }, 477 },
478 "options_language_ro": { 478 "options_language_ro": {
479 "description": "Language name shown in add language modal dialog", 479 "description": "Language name shown in add language modal dialog",
480 "message": "Romanian" 480 "message": "Romanian"
481 }, 481 },
482 "options_language_ru_uk": { 482 "options_language_ru_uk": {
483 "description": "Language name shown in add language modal dialog", 483 "description": "Language name shown in add language modal dialog",
484 "message": "Russian and Ukrainian" 484 "message": "Russian and Ukrainian"
485 } 485 }
486 } 486 }
LEFTRIGHT
« no previous file | new-options.html » ('j') | Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Toggle Comments ('s')

Powered by Google App Engine
This is Rietveld