Delta Between Two Patch Sets: new-options.html
Issue 29519636:
Issue 5538 - Implement "Help" tab for new options page (Closed)
Left Patch Set:
Created Aug. 23, 2017, 5:28 p.m.
Right Patch Set:
Created Aug. 25, 2017, 10:54 a.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | 3 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 4 - Copyright (C) 2006-present eyeo GmbH | 4 - Copyright (C) 2006-present eyeo GmbH |
| 5 - | 5 - |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | 6 - Adblock Plus is free software: you can redistribute it and/or modify |
| 7 - it under the terms of the GNU General Public License version 3 as | 7 - it under the terms of the GNU General Public License version 3 as |
| 8 - published by the Free Software Foundation. | 8 - published by the Free Software Foundation. |
| 9 - | 9 - |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | 10 - Adblock Plus is distributed in the hope that it will be useful, |
| (...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 288 <button class="i18n_options_customFilter_save" data-action="save -custom-filters"> | 288 <button class="i18n_options_customFilter_save" data-action="save -custom-filters"> |
| 289 </button> | 289 </button> |
| 290 <button class="i18n_options_customFilter_cancel" data-action="ca ncel-custom-filters"> | 290 <button class="i18n_options_customFilter_cancel" data-action="ca ncel-custom-filters"> |
| 291 </button> | 291 </button> |
| 292 </div> | 292 </div> |
| 293 </div> | 293 </div> |
| 294 </section> | 294 </section> |
| 295 </div> | 295 </div> |
| 296 | 296 |
| 297 <!-- Help tab content --> | 297 <!-- Help tab content --> |
| 298 <div id="content-help" role="tabpanel" aria-labelledby="tab-help"> | 298 <div id="content-help" role="tabpanel" aria-labelledby="tab-help"> |
|
ire
2017/08/24 09:17:47
There is no aria-hidden attribute attribute on the
saroyanm
2017/08/24 13:22:27
I agree, I think we should improve that separately
ire
2017/08/25 08:52:49
Acknowledged.
| |
| 299 <h1 class="i18n_options_tab_help"></h1> | 299 <h1 class="i18n_options_tab_help"></h1> |
| 300 <p class="i18n_options_help_description"></p> | 300 <p class="i18n_options_help_description"></p> |
| 301 <section> | 301 <section> |
| 302 <h2 class="i18n_options_support_title"></h2> | 302 <h2 class="i18n_options_support_title"></h2> |
| 303 <ul> | 303 <ul> |
| 304 <li id="report-issue" class="i18n_options_report_issue"></li> | 304 <li id="report-issue" class="i18n_options_report_issue"></li> |
| 305 <li id="report-ad" class="i18n_options_report_ad"></li> | 305 <li id="report-ad" class="i18n_options_report_ad"></li> |
| 306 <li id="report-bug" class="i18n_options_report_bug"></li> | 306 <li id="report-bug" class="i18n_options_report_bug"></li> |
| 307 <li id="report-forum" class="i18n_options_report_forum"></li> | 307 <li id="report-forum" class="i18n_options_report_forum"></li> |
| 308 </ul> | 308 </ul> |
| 309 </section> | 309 </section> |
| 310 <section> | 310 <section> |
| 311 <h2 class="i18n_options_social_title"></h2> | 311 <h2 class="i18n_options_social_title"></h2> |
| 312 <p class="i18n_options_social_description"></p> | 312 <p class="i18n_options_social_description"></p> |
| 313 <div id="social"> | 313 <div id="social"> |
| 314 <ul id="social-general"> | 314 <ul id="social-general"> |
| 315 <li><a id="twitter">Twitter</a></li> | 315 <li><a id="twitter">Twitter</a></li> |
| 316 <li><a id="facebook">Facebook</a></li> | 316 <li><a id="facebook">Facebook</a></li> |
| 317 <li><a id="google-plus">Google Plus</a></li> | 317 <li><a id="google-plus">Google Plus</a></li> |
| 318 </ul> | 318 </ul> |
| 319 <ul id="social-chinese"> | 319 <ul id="social-chinese"> |
|
ire
2017/08/24 09:17:47
NIT: I think the class name "social-zh" may be mor
saroyanm
2017/08/24 13:22:28
I think we shouldn't put implementation details in
ire
2017/08/25 08:52:49
Acknowledged.
| |
| 320 <li><a id="weibo">Weibo</a></li> | 320 <li><a id="weibo">Weibo</a></li> |
|
saroyanm
2017/08/23 17:36:10
Weibo icon is yet missing -> https://bitbucket.org
ire
2017/08/24 09:17:47
Acknowledged.
| |
| 321 </ul> | 321 </ul> |
| 322 <p> | 322 <p> |
|
ire
2017/08/24 09:17:47
This should be wrapped in a <strong> element, the
saroyanm
2017/08/24 13:22:28
agree
saroyanm
2017/08/24 18:19:42
Done.
| |
| 323 <span class="i18n_options_email"></span> | 323 <strong> |
| 324 <a href="mailto:support@adblockplus.org">support@adblockplus.org </a> | 324 <span class="i18n_options_email"></span> |
| 325 <a href="mailto:support@adblockplus.org">support@adblockplus.o rg</a> | |
| 326 </strong> | |
| 325 </p> | 327 </p> |
| 326 </div> | 328 </div> |
| 327 </section> | 329 </section> |
| 328 </div> | 330 </div> |
| 329 </div> | 331 </div> |
| 330 </div> | 332 </div> |
| 331 | 333 |
| 332 <!-- Dialog --> | 334 <!-- Dialog --> |
| 333 <div id="dialog" role="dialog" aria-hidden="true"> | 335 <div id="dialog" role="dialog" aria-hidden="true"> |
| 334 <header> | 336 <header> |
| (...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 375 <div class="url"></div> | 377 <div class="url"></div> |
| 376 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> | 378 <button class="i18n_options_dialog_predefined_confirm default-focus" data-action="add-predefined-subscription"></button> |
| 377 </div> | 379 </div> |
| 378 </div> | 380 </div> |
| 379 </div> | 381 </div> |
| 380 <!-- Placeholder element to determine when to wrap focus around --> | 382 <!-- Placeholder element to determine when to wrap focus around --> |
| 381 <span class="focus-last" tabindex="0"></span> | 383 <span class="focus-last" tabindex="0"></span> |
| 382 </div> | 384 </div> |
| 383 </body> | 385 </body> |
| 384 </html> | 386 </html> |
| LEFT | RIGHT |
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
