Unified Diff: new-options.html
Issue 29519636:
Issue 5538 - Implement "Help" tab for new options page (Closed)
Patch Set:
Created Aug. 23, 2017, 5:28 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« locale/en-US/new-options.json ('K')
|
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
skin/new-options.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: new-options.html |
| =================================================================== |
| --- a/new-options.html |
| +++ b/new-options.html |
| @@ -296,29 +296,35 @@ |
| <!-- Help tab content --> |
| <div id="content-help" role="tabpanel" aria-labelledby="tab-help"> |
|
ire
2017/08/24 09:17:47
There is no aria-hidden attribute attribute on the
saroyanm
2017/08/24 13:22:27
I agree, I think we should improve that separately
ire
2017/08/25 08:52:49
Acknowledged.
|
| - <h1 class="i18n_options_faq_title"></h1> |
| - <p class="i18n_options_faq_description"></p> |
| - <p> |
| - <a id="link-faq" class="i18n_options_faq_title" target="_blank"></a> |
| - </p> |
| - <h1 class="i18n_options_forum_title"></h1> |
| - <p class="i18n_options_forum_description"></p> |
| - <p> |
| - <a id="link-forum" class="i18n_options_forum_link" target="_blank"></a> |
| - </p> |
| - <h1 class="i18n_options_media_title"></h1> |
| - <p class="i18n_options_media_description"></p> |
| - <p> |
| - <span id="share-general"> |
| - <a id="link-twitter" target="_blank">Twitter</a> |
| - <a id="link-facebook" target="_blank">Facebook</a> |
| - <a id="link-gplus" target="_blank">Google+</a> |
| - </span> |
| - <span id="share-chinese"> |
| - <a id="link-renren" target="_blank">renren</a> |
| - <a id="link-weibo" target="_blank">weibo</a> |
| - </span> |
| - </p> |
| + <h1 class="i18n_options_tab_help"></h1> |
| + <p class="i18n_options_help_description"></p> |
| + <section> |
| + <h2 class="i18n_options_support_title"></h2> |
| + <ul> |
| + <li id="report-issue" class="i18n_options_report_issue"></li> |
| + <li id="report-ad" class="i18n_options_report_ad"></li> |
| + <li id="report-bug" class="i18n_options_report_bug"></li> |
| + <li id="report-forum" class="i18n_options_report_forum"></li> |
| + </ul> |
| + </section> |
| + <section> |
| + <h2 class="i18n_options_social_title"></h2> |
| + <p class="i18n_options_social_description"></p> |
| + <div id="social"> |
| + <ul id="social-general"> |
| + <li><a id="twitter">Twitter</a></li> |
| + <li><a id="facebook">Facebook</a></li> |
| + <li><a id="google-plus">Google Plus</a></li> |
| + </ul> |
| + <ul id="social-chinese"> |
|
ire
2017/08/24 09:17:47
NIT: I think the class name "social-zh" may be mor
saroyanm
2017/08/24 13:22:28
I think we shouldn't put implementation details in
ire
2017/08/25 08:52:49
Acknowledged.
|
| + <li><a id="weibo">Weibo</a></li> |
|
saroyanm
2017/08/23 17:36:10
Weibo icon is yet missing -> https://bitbucket.org
ire
2017/08/24 09:17:47
Acknowledged.
|
| + </ul> |
| + <p> |
|
ire
2017/08/24 09:17:47
This should be wrapped in a <strong> element, the
saroyanm
2017/08/24 13:22:28
agree
saroyanm
2017/08/24 18:19:42
Done.
|
| + <span class="i18n_options_email"></span> |
| + <a href="mailto:support@adblockplus.org">support@adblockplus.org</a> |
| + </p> |
| + </div> |
| + </section> |
| </div> |
| </div> |
| </div> |
« locale/en-US/new-options.json ('K')
|
« locale/en-US/new-options.json ('k')
|
new-options.js » ('j')
|
skin/new-options.css » ('J')
