Issue 5540 - implement notification

new-options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 414 matching lines @@
     }
   }
 
   function updateFilter(filter)
   {
     let match = filter.text.match(whitelistedDomainRegexp);
     if (match && !filtersMap[filter.text])
     {
       filter.title = match[1];
       collections.whitelist.addItem(filter);
+      if (isCustomFiltersLoaded)
+      {
+        let text = getMessage("options_whitelist_notification", [filter.title]);
+        showNotification(text);
+      }
     }
     else
     {
       customFilters.push(filter.text);
       if (isCustomFiltersLoaded)
         updateCustomFiltersUi();
     }
 
     filtersMap[filter.text] = filter;
   }
@@ skipping 136 matching lines @@
             break;
           }
         }
         break;
       case "close-dialog":
         closeDialog();
         break;
       case "edit-custom-filters":
         setCustomFiltersView("write");
         break;
+      case "hide-notification":
+        hideNotification();
+        break;
       case "import-subscription": {
         let url = E("blockingList-textbox").value;
         addEnableSubscription(url);
         closeDialog();
         break;
       }
       case "open-context-menu": {
         let listItem = findParentData(element, "access", true);
         if (listItem && !listItem.classList.contains("show-context-menu"))
           listItem.classList.add("show-context-menu");
@@ skipping 385 matching lines @@
 
   function closeDialog()
   {
     let dialog = E("dialog");
     dialog.setAttribute("aria-hidden", true);
     dialog.removeAttribute("aria-labelledby");
     document.body.removeAttribute("data-dialog");
     focusedBeforeDialog.focus();
   }
 
+  function showNotification(text)
+  {
+    E("notification").setAttribute("aria-hidden", false);

[ire, 2017/08/24 10:08:44]

The aria-live attribute could also be relevant here (see
https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Live_Reg...)

[saroyanm, 2017/08/24 14:18:25]

Agree

[saroyanm, 2017/08/24 18:40:54]

Done.

+    E("notification-text").textContent = text;
+    setTimeout(hideNotification, 3000);

[ire, 2017/08/24 10:08:43]

(Personal Opinion) I think 3 seconds is too short

[saroyanm, 2017/08/24 14:18:26]

That's specified in the specs, let's be consistent for now with specs to be able
to finish the page until it's not critical, but I agree that this is something
that make sense to bring to the discussion during the next meeting.

[ire, 2017/08/25 09:59:44]

Acknowledged.

+  }
+
+  function hideNotification()
+  {
+    E("notification").setAttribute("aria-hidden", true);

[ire, 2017/08/24 10:08:44]

NIT: Clear the textContent as well?

[saroyanm, 2017/08/24 14:18:26]

Yes, I'll update that.

[saroyanm, 2017/08/24 18:40:54]

Done.

+  }
+
   function setAcceptableAds()
   {
     let option = "none";
     document.forms["acceptable-ads"].classList.remove("show-dnt-notification");
     if (acceptableAdsUrl in subscriptionsMap)
     {
       option = "ads";
     }
     else if (acceptableAdsPrivacyUrl in subscriptionsMap)
     {
@@ skipping 361 matching lines @@
   });
   ext.backgroundPage.sendMessage({
     type: "subscriptions.listen",
     filter: ["added", "disabled", "homepage", "lastDownload", "removed",
              "title", "downloadStatus", "downloading"]
   });
 
   window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
   window.addEventListener("hashchange", onHashChange, false);
 }